cmake conversion #1

Sammanfogat
SlavekB sammanfogade 1 incheckningar från feat/cmakeConv in i master 5 år sedan
Ghost kommenterad 5 år sedan

I've added a man page taken from your Debian packaging system.

I've added a man page taken from your Debian packaging system.
SlavekB granskad av 5 år sedan
SlavekB lämnade en kommentar
Ägare

Please, give attention to my comments below. For now, I did not test it but it looks good.

Please, give attention to my comments below. For now, I did not test it but it looks good.
include(TestBigEndian)
test_big_endian(WORDS_BIGENDIAN)
SlavekB kommenterad 5 år sedan
Ägare

Please add here as another standard test:

tde_setup_largefiles( )
Please add here as another standard test: ``` tde_setup_largefiles( ) ```
set( __KDE_HAVE_GCC_VISIBILITY 1 )
set( CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fvisibility=hidden -fvisibility-inlines-hidden")
set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fvisibility=hidden -fvisibility-inlines-hidden")
endif( WITH_GCC_VISIBILITY )
SlavekB kommenterad 5 år sedan
Ägare

Please use a new common test:

tde_setup_gcc_visibility( )
Please use a new common test: ``` tde_setup_gcc_visibility( ) ```
if( NOT MSGFMT_EXECUTABLE )
tde_message_fatal( "msgfmt is required but was not found on your system." )
endif( NOT MSGFMT_EXECUTABLE )
endif( BUILD_TRANSLATIONS )
SlavekB kommenterad 5 år sedan
Ägare

This is no longer needed – it is automatically served by the new common test tde_setup_msgfmt( ).

This is no longer needed – it is automatically served by the new common test `tde_setup_msgfmt( )`.
Ghost added the PR/wip label 5 år sedan
Ghost added ST/wontfix and removed PR/wip labels 5 år sedan
Ghost kommenterad 5 år sedan
Skapare

So many change in the cmake modules, I get lost.
Feel free to add/change anything, I won't work on kshudown anymore.

So many change in the cmake modules, I get lost. Feel free to add/change anything, I won't work on kshudown anymore.
SlavekB kommenterad 5 år sedan
Ägare

Okay, that's no problem. Changes in the common cmake module are not large and most represent simplification for individual projects. I'll finish it.

Okay, that's no problem. Changes in the common cmake module are not large and most represent simplification for individual projects. I'll finish it.
SlavekB removed the ST/wontfix label 5 år sedan
SlavekB tilldelade denna till sig själv 5 år sedan
SlavekB added the PR/wip label 5 år sedan
SlavekB removed the PR/wip label 5 år sedan
SlavekB closed this pull request 5 år sedan
SlavekB tog bort grenen feat/cmakeConv 5 år sedan
SlavekB lade till denna till milstolpe R14.0.6 release 5 år sedan
Pull-förfrågan har sammanfogats som ffbcad84f2.
Logga in för att delta i denna konversation.
Inga granskare
Ingen Milsten
Ingen tilldelad
2 Deltagare
Notiser
Förfallodatum

Inget förfallodatum satt.

Beroenden

No dependencies set.

Reference: TDE/kshutdown#1
Laddar…
Det finns inget innehåll än.