TDE
/
kvirc
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

Replace various strings '#define'd in tqtinterface #16

Merged
MicheleC merged 1 commits from replace/qt-defines into master 5 months ago
Conversation 0 Commits 1 Files Changed 2
MicheleC commented 5 months ago
Owner

Those strings will later be removed from tqtinterface.

Those strings will later be removed from tqtinterface.
MicheleC added this to the R14.1.2 release milestone 5 months ago
MicheleC added 1 commit 5 months ago
ef6a18b3b2
Replace various strings '#define'd in tqtinterface
MicheleC requested review from Core 5 months ago
MicheleC requested review from Owners 5 months ago
SlavekB requested changes 5 months ago
SlavekB left a comment
Owner

Although it is not directly related, it is a suitable moment to fix a typo when it has so accentuated.

Although it is not directly related, it is a suitable moment to fix a typo when it has so accentuated.
src/modules/editor/scripteditor.cpp
void KviScriptEditorWidget::slotReplace()
{
KviScriptEditorReplaceDialog *dialog=new KviScriptEditorReplaceDialog(this,tqtr("Find & Repalce"));
KviScriptEditorReplaceDialog *dialog=new KviScriptEditorReplaceDialog(this,tr("Find & Repalce"));
SlavekB commented 5 months ago
Owner

We could also fix a typo – Repalce => Replace.

We could also fix a typo – Repalce => Replace.
MicheleC commented 5 months ago
Poster
Owner

Good catch. PR updated.

Good catch. PR updated.
MicheleC marked this conversation as resolved
MicheleC force-pushed replace/qt-defines from ef6a18b3b2 to 3c626b9f1a 5 months ago
MicheleC requested review from SlavekB 5 months ago
SlavekB approved these changes 5 months ago
SlavekB left a comment
Owner

It looks good.

It looks good.
MicheleC merged commit 3c626b9f1a into master 5 months ago
MicheleC deleted branch replace/qt-defines 5 months ago

Reviewers

SlavekB approved these changes 5 months ago
TDE/Core was requested for review 5 months ago
The pull request has been merged as 3c626b9f1a.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
TDE/Core
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.2 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/kvirc#16
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'replace/qt-defines'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes