Use new TQ_METHOD, TQ_SIGNAL, TQ_SLOT defines #20

Merged
MicheleC merged 1 commits from replace/signal-n-slot into master 4 months ago
Owner

As per title.

As per title.
MicheleC added this to the R14.1.2 release milestone 4 months ago
MicheleC added 1 commit 4 months ago
c0acd68573
Use new TQ_METHOD, TQ_SIGNAL, TQ_SLOT defines
MicheleC requested review from Core 4 months ago
MicheleC requested review from Owners 4 months ago
MicheleC force-pushed replace/signal-n-slot from c0acd68573 to 0dc42f763d 4 months ago
MicheleC force-pushed replace/signal-n-slot from 0dc42f763d to a2b25cd393 4 months ago
MicheleC force-pushed replace/signal-n-slot from a2b25cd393 to 209ac1e561 4 months ago
SlavekB requested changes 4 months ago
SlavekB left a comment
Owner

There are several cases where METHOD are not TQt methods. Of course it's just part of the comment.

There are several cases where `METHOD` are not TQt methods. Of course it's just part of the comment.
// NMETHODS field contains the number of method identifier octets that
// appear in the METHODS field.
// The values currently defined for TQT_METHOD are:
// The values currently defined for METHOD are:
Owner

These are not TQt methods.

These are not TQt methods.
Poster
Owner

I believe you were reviewing the PR before my second update (commit 209ac1e561). These wrong METHOD renames have already been fixed. Fyi, I usually push the PR first and the review, because TGW highlights the changes much better than git does.

I believe you were reviewing the PR before my second update (commit 209ac1e561). These wrong `METHOD` renames have already been fixed. Fyi, I usually push the PR first and the review, because TGW highlights the changes much better than git does.
Owner

Now it looks fine. Maybe there was just a coincidence in the time of time.

Now it looks fine. Maybe there was just a coincidence in the time of time.
SlavekB marked this conversation as resolved
{
// The server selects from one of the methods given in METHODS, and
// sends a TQT_METHOD selection message:
// sends a METHOD selection message:
Owner

These are not TQt methods.

These are not TQt methods.
SlavekB marked this conversation as resolved
//
// +----+--------+
// |VER | TQT_METHOD |
// |VER | METHOD |
Owner

These are not TQt methods.

These are not TQt methods.
SlavekB marked this conversation as resolved
// +----+--------+
//
// If the selected TQT_METHOD is X'FF', none of the methods listed by the
// If the selected METHOD is X'FF', none of the methods listed by the
Owner

These are not TQt methods.

These are not TQt methods.
SlavekB marked this conversation as resolved
// client are acceptable, and the client MUST close the connection.
//
// The values currently defined for TQT_METHOD are:
// The values currently defined for METHOD are:
Owner

These are not TQt methods.

These are not TQt methods.
SlavekB marked this conversation as resolved
SlavekB approved these changes 4 months ago
SlavekB left a comment
Owner

All seems good.

All seems good.
MicheleC merged commit 209ac1e561 into master 4 months ago
MicheleC deleted branch replace/signal-n-slot 4 months ago

Reviewers

SlavekB approved these changes 4 months ago
TDE/Core was requested for review 4 months ago
The pull request has been merged as 209ac1e561.
Sign in to join this conversation.
No reviewers
TDE/Core
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/kvirc#20
Loading…
There is no content yet.