cmake conversion #3

Unito
SlavekB ha unito 1 commit da feat/cmakeConv a master 5 anni fa
Ghost 5 anni fa ha commentato

The "doc" and "po" folder are actually empty, as a result I've left them commented in the CMakeLists.txt.

I've added some options for the user to pass where It was marked as FIXME in src/libtdeldap.cpp.

The "doc" and "po" folder are actually empty, as a result I've left them commented in the CMakeLists.txt. I've added some options for the user to pass where It was marked as FIXME in src/libtdeldap.cpp.
Ghost ha aggiunto l'etichetta PR/rfc 5 anni fa
SlavekB 'ha iniziato a lavorare 5 anni fa`
SlavekB ha smesso di funzionare 5 anni fa
1h 55min 5s
SlavekB 5 anni fa ha commentato
Proprietario

As expected, further work was needed.

  1. The Heimdal C API is used in the master branch; therefore, for Kerberos should be preferred Heimdal and we need to make sure that Kerberos is Heimdal.
  2. To prevent portability issue, I added the detection whether the compiler supports the option -fpermissive.
  3. The library version was 1.0.0 for Automake build, so I added the same version for CMake build.
  4. Because there are big differences between the master branch and r14.0.x, there was a need for further work with the backport for the r14.0.x branch.

Please test building on your system before I'll go ahead to merge.

As expected, further work was needed. 1. The Heimdal C API is used in the master branch; therefore, for Kerberos should be preferred Heimdal and we need to make sure that Kerberos is Heimdal. 2. To prevent portability issue, I added the detection whether the compiler supports the option -fpermissive. 3. The library version was 1.0.0 for Automake build, so I added the same version for CMake build. 4. Because there are big differences between the master branch and r14.0.x, there was a need for further work with the backport for the r14.0.x branch. Please test building on your system before I'll go ahead to merge.
SlavekB Titolo modificato da cmake conversion a WIP: cmake conversion 5 anni fa
SlavekB ha aggiunto l'etichetta PR/wip 5 anni fa
SlavekB 5 anni fa ha commentato
Proprietario

Although libtdeldap is a library, in the libtdeldap.h header, no class is marked as exported. And some classes with the Private note are used in other applications – such as LDAPPamConfig in kcmldap.

This is not compatible with hidden visibility. That's why we need more work to fix it.

Although libtdeldap is a library, in the libtdeldap.h header, no class is marked as exported. And some classes with the Private note are used in other applications – such as LDAPPamConfig in kcmldap. This is not compatible with hidden visibility. That's why we need more work to fix it.
SlavekB 5 anni fa ha commentato
Proprietario

Thanks to commit 32c6b4398e is now possible to build libtdeldap with gcc hidden visibility.

Thanks to commit 32c6b4398e is now possible to build libtdeldap with gcc hidden visibility.
SlavekB Titolo modificato da WIP: cmake conversion a cmake conversion 5 anni fa
SlavekB rimosso l'etichetta PR/wip 5 anni fa
SlavekB chiusa questa pull request 5 anni fa
SlavekB rimosso l'etichetta PR/rfc 5 anni fa
SlavekB branch feat/cmakeConv eliminato 5 anni fa
SlavekB aggiunta alle pietre miliari R14.0.6 release 5 anni fa
La pull request è stata unita come cdbb1c0a4c.
Effettua l'accesso per partecipare alla conversazione.
Nessun revisore
Nessuna milestone
Nessuna assegnatario
2 Partecipanti
Notifiche
Totale tempo trascorso: 1 hour 55 minutes
SlavekB
1 hour 55 minutes
Data di scadenza

Nessuna data di scadenza impostata.

Dipendenze

Nessuna dipendenza impostata.

Riferimento: TDE/libtdeldap#3
Caricamento…
Non ci sono ancora contenuti.