cmake conversion #3

已合并
SlavekB 5 年前 将 1 次代码提交从 feat/cmakeConv 合并至 master
Ghost 评论于 5 年前

The "doc" and "po" folder are actually empty, as a result I've left them commented in the CMakeLists.txt.

I've added some options for the user to pass where It was marked as FIXME in src/libtdeldap.cpp.

The "doc" and "po" folder are actually empty, as a result I've left them commented in the CMakeLists.txt. I've added some options for the user to pass where It was marked as FIXME in src/libtdeldap.cpp.
Ghost5 年前 添加了标签 PR/rfc
SlavekB 开始工作 5 年前
SlavekB 停止工作 5 年前
1h 55min 5s
SlavekB 评论于 5 年前
所有者

As expected, further work was needed.

  1. The Heimdal C API is used in the master branch; therefore, for Kerberos should be preferred Heimdal and we need to make sure that Kerberos is Heimdal.
  2. To prevent portability issue, I added the detection whether the compiler supports the option -fpermissive.
  3. The library version was 1.0.0 for Automake build, so I added the same version for CMake build.
  4. Because there are big differences between the master branch and r14.0.x, there was a need for further work with the backport for the r14.0.x branch.

Please test building on your system before I'll go ahead to merge.

As expected, further work was needed. 1. The Heimdal C API is used in the master branch; therefore, for Kerberos should be preferred Heimdal and we need to make sure that Kerberos is Heimdal. 2. To prevent portability issue, I added the detection whether the compiler supports the option -fpermissive. 3. The library version was 1.0.0 for Automake build, so I added the same version for CMake build. 4. Because there are big differences between the master branch and r14.0.x, there was a need for further work with the backport for the r14.0.x branch. Please test building on your system before I'll go ahead to merge.
SlavekB5 年前 修改标题 cmake conversionWIP: cmake conversion
SlavekB5 年前 添加了标签 PR/wip
SlavekB 评论于 5 年前
所有者

Although libtdeldap is a library, in the libtdeldap.h header, no class is marked as exported. And some classes with the Private note are used in other applications – such as LDAPPamConfig in kcmldap.

This is not compatible with hidden visibility. That's why we need more work to fix it.

Although libtdeldap is a library, in the libtdeldap.h header, no class is marked as exported. And some classes with the Private note are used in other applications – such as LDAPPamConfig in kcmldap. This is not compatible with hidden visibility. That's why we need more work to fix it.
SlavekB 评论于 5 年前
所有者

Thanks to commit 32c6b4398e is now possible to build libtdeldap with gcc hidden visibility.

Thanks to commit 32c6b4398e is now possible to build libtdeldap with gcc hidden visibility.
SlavekB5 年前 修改标题 WIP: cmake conversioncmake conversion
SlavekB5 年前 删除了标签 PR/wip
SlavekB5 年前 关闭此合并请求
SlavekB5 年前 删除了标签 PR/rfc
SlavekB5 年前 删除了分支 feat/cmakeConv
SlavekB5 年前 添加了里程碑 R14.0.6 release
该合并请求已作为 cdbb1c0a4c 被合并。
登录 并参与到对话中。
无审核者
未选择里程碑
未指派成员
2 名参与者
通知
总花费时间:1 hour 55 minutes
SlavekB
1 hour 55 minutes
到期时间

未设置到期时间。

依赖工单

没有设置依赖项。

参考:TDE/libtdeldap#3
正在加载...
这个人很懒,什么都没留下。