TDE
/
pytqt
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

Drop compatibility code for TQPalette #21

Merged
MicheleC merged 1 commits from drop/tqpalette-compat-code into master 10 months ago
Conversation 1 Commits 1 Files Changed 2
MicheleC commented 10 months ago
Owner

Related TQPalette methods will later be removed from TQt3.

Related TQPalette methods will later be removed from TQt3.
MicheleC added 1 commit 10 months ago
aa6764916f
Drop compatibility code for TQPalette
MicheleC requested review from Core 10 months ago
MicheleC requested review from Owners 10 months ago
SlavekB approved these changes 10 months ago
SlavekB left a comment
Owner

It seems good.
At first I was afraid that changing the order in enum would be a problem, but then I noticed that the order did not match the TQt3 anyway. So it is probably evaluated in another way.

It seems good. At first I was afraid that changing the order in enum would be a problem, but then I noticed that the order did not match the TQt3 anyway. So it is probably evaluated in another way.
MicheleC merged commit aa6764916f into master 10 months ago
MicheleC deleted branch drop/tqpalette-compat-code 10 months ago
MicheleC added this to the R14.2.0 release milestone 10 months ago
MicheleC commented 10 months ago
Poster
Owner

It seems good.
At first I was afraid that changing the order in enum would be a problem, but then I noticed that the order did not match the TQt3 anyway. So it is probably evaluated in another way.

I think the order was wrong here, because TQt3 has a different order. My best guess is that previous Qt versions had Normal as first element and pytqt was never updated to the latest version.

> It seems good. > At first I was afraid that changing the order in enum would be a problem, but then I noticed that the order did not match the TQt3 anyway. So it is probably evaluated in another way. I think the order was wrong here, because TQt3 has a different order. My best guess is that previous Qt versions had Normal as first element and pytqt was never updated to the latest version.

Reviewers

SlavekB approved these changes 10 months ago
TDE/Core was requested for review 10 months ago
The pull request has been merged as aa6764916f.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
TDE/Core
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.2.0 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/pytqt#21
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'drop/tqpalette-compat-code'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes