Add support for python 3.12 #26

Merged
MicheleC merged 1 commits from fix/python-3.12 into master 3 months ago
Owner

This requires Python 3.4 or higher.

In deb distros, to build with TDE/tde-packaging#273.

This requires Python 3.4 or higher. In deb distros, to build with TDE/tde-packaging#273.
MicheleC added this to the R14.1.2 release milestone 3 months ago
MicheleC added 1 commit 3 months ago
2d6e99455e
Add support for python 3.12
MicheleC requested review from Core 3 months ago
MicheleC requested review from Owners 3 months ago
SlavekB approved these changes 3 months ago
SlavekB left a comment
Owner

Building successfully tested on Debian Sid (Python 3.11 and 3.12) and Ubuntu Bionic (Python 3.6).

Building successfully tested on Debian Sid (Python 3.11 and 3.12) and Ubuntu Bionic (Python 3.6).
Owner

In Debian rules, I have only a change in pylib detection to make a configuration file installed for each individual version. Instead of the original line I used:

pylib=$$(python$$version -c "import os; import sysconfig; print (os.path.join(sysconfig.get_path('platstdlib'), 'dist-packages', 'PyTQt'))")
In Debian rules, I have only a change in `pylib` detection to make a configuration file installed for each individual version. Instead of the original line I used: ``` pylib=$$(python$$version -c "import os; import sysconfig; print (os.path.join(sysconfig.get_path('platstdlib'), 'dist-packages', 'PyTQt'))") ```
obache requested changes 3 months ago
obache left a comment
Collaborator

PY_VERSION_HEX < 0x03030000 part must not be changed,
because PyUnicode_GET_LENGTH is new in version 3.3.
Or drop the condition and part completely, because other files are replaced unconditionally,
if python<3.3 is not supported.

`PY_VERSION_HEX < 0x03030000` part must not be changed, because `PyUnicode_GET_LENGTH` is new in version 3.3. Or drop the condition and part completely, because other files are replaced unconditionally, if python<3.3 is not supported.
Poster
Owner
pylib=$$(python$$version -c "import os; import sysconfig; print (os.path.join(sysconfig.get_path('platstdlib'), 'dist-packages', 'PyTQt'))")

😄 I used pretty much the same code

pylib=$$(python$$version -c "import sysconfig; print(sysconfig.get_path('platstdlib'))")/dist-packages/PyTQt;\

But as told you on jabber, there is an issue with sip4-tqt that we need to fix before we merge this PR.

> ``` > pylib=$$(python$$version -c "import os; import sysconfig; print (os.path.join(sysconfig.get_path('platstdlib'), 'dist-packages', 'PyTQt'))") > ``` 😄 I used pretty much the same code ``` pylib=$$(python$$version -c "import sysconfig; print(sysconfig.get_path('platstdlib'))")/dist-packages/PyTQt;\ ``` But as told you on jabber, there is an issue with `sip4-tqt` that we need to fix before we merge this PR.
Poster
Owner

Or drop the condition and part completely, because other files are replaced unconditionally,
if python<3.3 is not supported.

Good point, we can drop the condition all together since the oldest supported python we are buildign for is something like 3.5 or 3.7.

> Or drop the condition and part completely, because other files are replaced unconditionally, > if python<3.3 is not supported. Good point, we can drop the condition all together since the oldest supported python we are buildign for is something like 3.5 or 3.7.
MicheleC force-pushed fix/python-3.12 from 2d6e99455e to 3df8c0b3f4 3 months ago
Poster
Owner

PR updated.

PR updated.
SlavekB approved these changes 3 months ago
SlavekB left a comment
Owner

Removing the condition looks good because we now require Python >= 3.3.

Removing the condition looks good because we now require Python >= 3.3.
MicheleC force-pushed fix/python-3.12 from 3df8c0b3f4 to 15eb6c387b 3 months ago
MicheleC requested review from obache 3 months ago
MicheleC requested review from SlavekB 3 months ago
Poster
Owner

We now need python 3.4 for sip4-tqt, so I have updated the conditions again.

We now need python 3.4 for sip4-tqt, so I have updated the conditions again.
SlavekB approved these changes 3 months ago
SlavekB left a comment
Owner

All looks good.

All looks good.
MicheleC merged commit 15eb6c387b into master 3 months ago
MicheleC deleted branch fix/python-3.12 3 months ago

Reviewers

obache was requested for review 3 months ago
SlavekB approved these changes 3 months ago
TDE/Core was requested for review 3 months ago
The pull request has been merged as 15eb6c387b.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Reference: TDE/pytqt#26
Loading…
There is no content yet.