TDE
/
sip4-tqt
6
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity
Labels Milestones

Fix FTBFS for build out of source #4

Merged
SlavekB merged 3 commits from issue/3/fix-ftbfs-for-build-out-of-source into master 2 years ago
Conversation 0 Commits 3 Files Changed 5
SlavekB commented 2 years ago
Owner

Several problems are solved here:

  1. FTBFS, if new *.c files are generated for lexer or parser – thank you Michele for your patch.
  2. When generating a new parser.c, it is also appropriate to generate parser.h to make these files consistent. Therefore, the default make rule is not sufficient, but explicit rule is needed.
  3. There was inconsistency in the definition of constants between parser.h and parser.c contained in the source tree. If the new parser.h has been automatically generated, it caused FTBFS in the lexer.
  4. None of these generated files may be part of the source tree.
Several problems are solved here: 1. FTBFS, if new `*.c` files are generated for lexer or parser – thank you Michele for your patch. 2. When generating a new `parser.c`, it is also appropriate to generate `parser.h` to make these files consistent. Therefore, the default make rule is not sufficient, but explicit rule is needed. 3. There was inconsistency in the definition of constants between `parser.h` and `parser.c` contained in the source tree. If the new `parser.h` has been automatically generated, it caused FTBFS in the lexer. 4. None of these generated files may be part of the source tree.
SlavekB added 3 commits 2 years ago
32d72527ff
Fix FTBFS for build outside the source code.
123b20b747
Add an explicit rule to generate parser.
c1d6f4a527
Fix the mismatch of tokens TK_TQOBJECT × TK_QOBJECT and
SlavekB added a new dependency 2 years ago
#3 FTBFS on Debian Buster
MicheleC approved these changes 2 years ago
MicheleC left a comment
Owner

Looks good

Looks good
SlavekB merged commit c1d6f4a527 into master 2 years ago
SlavekB deleted branch issue/3/fix-ftbfs-for-build-out-of-source 2 years ago
SlavekB added this to the R14.0.12 release milestone 2 years ago

Reviewers

MicheleC approved these changes 2 years ago
The pull request has been merged as c1d6f4a527.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MicheleC
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.12 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Blocks
#3 FTBFS on Debian Buster
TDE/sip4-tqt
Depends on
#109 Fix for issue sip4-tqt/issues/3
TDE/tde-packaging
Reference: TDE/sip4-tqt#4
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'issue/3/fix-ftbfs-for-build-out-of-source'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes