We can hold this PR until we update tdebindings. Although since ruby's bindings are broken, it won't make much of a difference whether we merge now or later. Just let me know your preference.
We can hold this PR until we update tdebindings. Although since ruby's bindings are broken, it won't make much of a difference whether we merge now or later. Just let me know your preference.
I double checked this, the Ruby module is already TQt, see here
I double checked this, the Ruby module is already `TQt`, see [here](https://mirror.git.trinitydesktop.org/gitea/TDE/tdebindings/src/branch/master/qtruby/rubylib/qtruby/lib/Qt/qtruby.rb#L20)
Isn't ruby's require statement operates upon filename (which is still Qt) rather than the package name?
Isn't ruby's `require` statement operates upon filename (which is [still Qt](https://mirror.git.trinitydesktop.org/gitea/TDE/tdebindings/src/commit/faf33629bb6562a6f43f930afafe4b22e9cdb60b/qtruby/rubylib/qtruby/lib)) rather than the package name?
I have no idea, I assumed it works on module names. If the file and module name needs to be the same, then we may have to fix that too. I will look into it.
I have no idea, I assumed it works on module names. If the file and module name needs to be the same, then we may have to fix that too. I will look into it.
Ruby's kernel require is "load the file once", and you can omit its extension.
We should rename files from Qt to TQt too, or such files may conflict with "QtRuby".
Ruby's kernel `require` is "`load` the file once", and you can omit its extension.
We should rename files from Qt to TQt too, or such files may conflict with "QtRuby".
Fat-Zer
As per title.
MicheleC referenced this pull request from TDE/tde 3 months agoThere is one thing for discussion.
beginrequire "Qt"require "TQt"TQt Ruby module in tdebinginds has been still installed as
Qt.rb(qtrubylibrary). We should first change tdebindings?We can hold this PR until we update tdebindings. Although since ruby's bindings are broken, it won't make much of a difference whether we merge now or later. Just let me know your preference.
I double checked this, the Ruby module is already
TQt, see hereIsn't ruby's
requirestatement operates upon filename (which is still Qt) rather than the package name?I have no idea, I assumed it works on module names. If the file and module name needs to be the same, then we may have to fix that too. I will look into it.
Ruby's kernel
requireis "loadthe file once", and you can omit its extension.We should rename files from Qt to TQt too, or such files may conflict with "QtRuby".
Thanks Obata-san, we will fix this 👍
Reviewers