cmake conversion #1

Merged
SlavekB merged 1 commits from feat/cmakeConv into master 5 years ago
Ghost commented 5 years ago

I've added a version to "tastymenu_panelapplet" like in the makefile but I'm not sure It's fine/necessary.
Like with the "tde-style-ia-ora" conversion, I don't have a deb package to compare with mine, furthermore I didn't test this package since I don't know how to use tastymenu.
This is for comments, please test.

I've added a version to "tastymenu_panelapplet" like in the makefile but I'm not sure It's fine/necessary. Like with the "tde-style-ia-ora" conversion, I don't have a deb package to compare with mine, furthermore I didn't test this package since I don't know how to use tastymenu. This is for comments, please test.
Ghost added the PR/rfc label 5 years ago
SlavekB reviewed 5 years ago
SlavekB left a comment
Owner

It looks good, I will test it. About the version - see the comment below.

It looks good, I will test it. About the version - see the comment below.
tastytooltip.cpp
tastybutton.cpp
prefs.kcfgc
VERSION 0.0.0
Owner

Since the tastymenu_panelapplet is a module, they are not versioned. Therefore VERSION is useless.

Since the tastymenu_panelapplet is a module, they are not versioned. Therefore VERSION is useless.
Ghost commented 5 years ago
Poster

Ah, thanks, good to know.
Would you remove It when you will be handling the auto ascii casting?

Ah, thanks, good to know. Would you remove It when you will be handling the auto ascii casting?
Owner

If you want, you can use it for training amend previous commit:

  1. Remove the line with the VERSION.
  2. git add --all
  3. git commit --amend -S
  4. git push origin -f HEAD
If you want, you can use it for training amend previous commit: 1. Remove the line with the VERSION. 2. `git add --all` 3. `git commit --amend -S` 4. `git push origin -f HEAD`
Ghost commented 5 years ago
Poster

ok, I'll give It a try tomorrow, I've already sparked up too much brain cells for today.

ok, I'll give It a try tomorrow, I've already sparked up too much brain cells for today.
Ghost commented 5 years ago
Poster

The forced update should have worked, thanks for the tip.

The forced update should have worked, thanks for the tip.
SlavekB approved these changes 5 years ago
SlavekB left a comment
Owner

Added common things like KDE_EXPORT, ui includes and ascii-cast. There seems to be nothing to prevent merging.

Added common things like KDE_EXPORT, ui includes and ascii-cast. There seems to be nothing to prevent merging.
SlavekB closed this pull request 5 years ago
SlavekB deleted branch feat/cmakeConv 5 years ago
SlavekB removed the PR/rfc label 5 years ago
SlavekB added this to the R14.1.0 release milestone 5 years ago
The pull request has been merged as 2a7cf2dd00.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tastymenu#1
Loading…
There is no content yet.