Labels Milestones

TDEArtwork: Add kclock USE for tdeartwork-tdescreensaver + Cosmetics. #153

Merged

Chris merged 1 commits from fix/tdeartwork into master 4 years ago

Conversation 0 Commits 1 Files Changed 12

Chris commented 4 years ago

Collaborator

We have the svg USE for nearly every ebuild, to get ride of the libart_lgpl dependency. It would be a schame if users would be forced to just install that then for only a single screensaver, which makes use of the functions of this library. Because that is not SVG related, we can't name it this way. So I found the name of the screensaver affecting it to be the best solution.

KMMODULE isn't used in the eclasses, so I removed it. Because the naming scheme for the folder IconThemes is very different than the rest of the tdeartwork components, the TSM_EXTRACT is needed, sadly. But maybe the folder can be renamed to icon-themes, so the CMake option and the folder name are consistent (like the rest), so we can ride of that too? 😸

Signed-off-by: Chris xchrisx@uber.space

We have the `svg` USE for nearly every ebuild, to get ride of the `libart_lgpl` dependency. It would be a schame if users would be forced to just install that then for only a single screensaver, which makes use of the functions of this library. Because that is not SVG related, we can't name it this way. So I found the name of the screensaver affecting it to be the best solution. `KMMODULE` isn't used in the eclasses, so I removed it. Because the naming scheme for the folder `IconThemes` is very different than the rest of the tdeartwork components, the `TSM_EXTRACT` is needed, sadly. But maybe the folder can be renamed to `icon-themes`, so the CMake option and the folder name are consistent (like the rest), so we can ride of that too? :smile_cat: Signed-off-by: Chris <xchrisx@uber.space>

Chris added this to the R14.1.0 release milestone 4 years ago

Chris closed this pull request 4 years ago

Chris deleted branch fix/tdeartwork 4 years ago

The pull request has been merged as fb63f1d372.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce

No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme

Milestone

Set milestone

Clear milestone

No items

No Milestone

R14.1.0 release

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-packaging-gentoo#153

Write Preview

Loading…

Cancel

Save

There is no content yet.