features/trinity-applications-stable-second-attempt #189

Version 14.0.8 ebuilds for as many packages in trinity-apps as I could make build back in June, plus trinity-base/kontact, which somehow got missed before. (Please junk the old features/trinity-applications-stable branch, which contains the same stuff, but in a crufted-up format that would have made it extremely painful to merge.)

pkgcheck doesn't seem to have much problem with these (if we ignore spew about whitespace, extra files in Manifests, and unrecognized i18n USE flags).

MR re-introduces superfluous 14.0.7 manifests. This is easily fixed by running repoman manifest inside trinity-apps directory. You can simply git commit --amend afterwards. You can also use this to change the commit message of current HEAD when needed.
Right now you have two commits, where the second one is just fixing stuff from the first; we don't need review noise in origin/master, so you can squash the commits easily using git rebase -i HEAD~2 (that's interactively choosing the desired action for the rebase).
Always run git status before and after such operations so you know where you are right now and that the previous command did what you expected.
In gentoo.git we have adopted a common workflow where we always prefix commits with category/packagename: and a limit to ~70 characters, in this case where you add new packages in one commit to the same category it would be category: prefix. It is good practice to be curt and precise in the git message (like x.x.x version bump) and have any detailed description or full sentences in the message body.
All style comments I made are not necessary must-have fixes, if there is a 9999 version I will most likely have already gone over it. If there is no 9999 yet, it would be nice to have your release version tidied up so I don't need to check again whenever a 9999 will be introduced (and likely use the release version as template).
All non-style comments would ideally be fixed in separate commits to the 9999 version, so they are not lost on subsequent version bumps.

I have yet to be able to get repoman to do anything useful with this overlay (it throws a fit about metadata files and quits, and I don't have the energy to figure out what's going on), and in any case, as long as the metadata files contain the needed signatures, extras don't matter. Only the automated tooling ever looks inside those files.

I'll try to get to the substansive problems (that is, the things that aren't just style complaints) after Christmas.

Upon further review, I see that:

-All the issues are inherited from the live ebuilds, rather than being things that I introduced.

-All of them except the dependency issues with kima and kbiff are stylistic even when not marked that way—that is, they don't break the ebuild. Actually, even the kima dep issue doesn't break the ebuild, it just removes some functionality.

As for kbiff, I don't actually use it, so I wouldn't be able to recognize abnormal behaviour short of it outright crashing. tdelibs-14.0.8 won't build for me with -ssl (the flag seems to be broken: it tries to compile SSL-related files anyway, then errors out when it can't find a related definition), so further testing is not possible at this time.

Some poking around with ldd suggests that kbiff doesn't directly link libssl or libcrypto when built with the ssl flag active, so it's probably drawing from tdelibs. (I suppose whoever coded it might also have directly reimplemented SSL, but why would you?)

Either merge the 14.0.8 ebuilds in here as-is or discard the whole thing altogether; I lack the energy to care which right now and just want the whole thing to go away.

Efforts have been made here and there is no point in throwing it away. I suggest merging it and resolving any issues and comments afterwards. Any objections?

 	dev-lang/ruby:*
 	media-libs/taglib
 	dev-db/sqlite
 	xine? ( <media-libs/xine-lib-1.2.10 )

 # Distributed under the terms of the GNU General Public License v2
 EAPI="7"
 TRINITY_MODULE_TYPE="applications"


				`inherit trinity-base-2`

				`DESCRIPTION="A complex calculator for TDE"`

 inherit trinity-base-2
 DESCRIPTION="A complex calculator for TDE"
 KEYWORDS="~amd64 ~x86"

 SLOT="${TRINITY_VER}"
 src_configure() {
 	mycmakeargs=(


				`inherit trinity-base-2`

				`DESCRIPTION="Advanced music player for TDE."`


				`SLOT="${TRINITY_VER}"`

				`IUSE+=" css dvd dvdr vcd debug alsa ffmpeg ffmpeg_all_codecs \`


				`IUSE+=" +ssl asus"`

				`# SSL support might need tdelibs build with +ssl USE.`


				`inherit trinity-base-2`

				`DESCRIPTION="Autostart module for KControl "`


				`SLOT="${TRINITY_VER}"`

				`# NVControl support needs the nvidia-settings package,`

 DESCRIPTION="Trinity personal information manager"
 KEYWORDS="~amd64 ~x86"
 COMMON_DEPEND="~trinity-base/libtdepim-${PV}

 DEPEND+=" $COMMON_DEPEND"
 RDEPEND+=" $COMMON_DEPEND"
 TSM_EXTRACT_ALSO="libtdepim/ libtdenetwork/"

features/trinity-applications-stable-second-attempt #189

Reviewers