TDE
/
tde-packaging-gentoo
5
1
Fork 0
Code Issues 17 Pull Requests 2 Releases Wiki Activity
Labels Milestones

Fixing build error for scripting-api submodule for tdeedu-doc #229

Merged
SlavekB merged 1 commits from feat/tdeedu-doc into master 2 years ago
Conversation 1 Commits 1 Files Changed 1
ormorph commented 2 years ago
Collaborator

Since the ${DOXYGEN_BINARY} variable is not defined in the configuration file, the scripting-api submodule is not buil. This hotfix resolves this issue.
In this fix, it was decided to add the FindDoxygen cmake module and replace the DOXYGEN_BINARY variable with the DOXYGEN_EXECUTABLE variable.

Since the ${DOXYGEN_BINARY} variable is not defined in the configuration file, the scripting-api submodule is not buil. This hotfix resolves this issue. In this fix, it was decided to add the `FindDoxygen` cmake module and replace the `DOXYGEN_BINARY` variable with the `DOXYGEN_EXECUTABLE` variable.
SlavekB requested changes 2 years ago
SlavekB left a comment
Owner

It seems to be less intervention to adjust the condition for DOXYGEN_BINARY detection in ConfigureChecks.cmake.

It seems to be less intervention to adjust the condition for `DOXYGEN_BINARY` detection in [ConfigureChecks.cmake](../tdeedu/src/branch/master/ConfigureChecks.cmake#L30).
ormorph force-pushed feat/tdeedu-doc from ad4bc10e17 to 77d39256e9 2 years ago
ormorph commented 2 years ago
Poster
Collaborator

It seems to be less intervention to adjust the condition for DOXYGEN_BINARY detection in ConfigureChecks.cmake.

Ok. I posted the changes.

> It seems to be less intervention to adjust the condition for DOXYGEN_BINARY detection in ConfigureChecks.cmake. Ok. I posted the changes.
SlavekB approved these changes 2 years ago
SlavekB left a comment
Owner

Thank you, it looks good.

Thank you, it looks good.
SlavekB merged commit 237d1faabc into master 2 years ago
SlavekB deleted branch feat/tdeedu-doc 2 years ago
SlavekB added this to the R14.1.0 release milestone 2 years ago

Reviewers

SlavekB approved these changes 2 years ago
The pull request has been merged as 237d1faabc.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.0 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-packaging-gentoo#229
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/tdeedu-doc'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes