Changing the TRINITY_MODULE_TYPE variable in live branch builds #232
Merged
SlavekB
merged 5 commits from feat/trinity-module into master 3 years ago
SlavekB
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'feat/trinity-module'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Changing the TRINITY MODULE_TYPE variable in live branch builds, added. These changes are necessary to prepare for the migration of ebuilds to the stable branch. These changes do not affect the build of the live branch. In subsequent PR, work will continue to unify ebuilds.
It looks good, only here is the question about kplayer × kmplayer – see below.
TRINITY_MODULE_TYPE="applications/multimedia"inherit trinity-base-2DESCRIPTION="KPlayer is a TDE media player based on mplayer."You can notice that there is both a kplayer and kmplayer in master branch. Therefore, the question is whether instead of renaming do a copy because the original ebuild is probably really designed for kplayer. In any case, the DESCRIPTION will need to be adjusted.
c373fa3ec1tobe41803fe83 years agoI decided not to touch this ebuild yet, I just deleted this commit. In the stable branch, this ebuild is simply not used.
662711ad48to93be2546733 years ago93be254673to89f9a2a1213 years ago89f9a2a121tofef70f5ebd3 years agoFinished adding TRINITY_MODULE_TYPE to live branch ebuilds. I think that this PR it will be possible to merge.
The next PR will need to deal with slots in ebuilds.
It looks good.
f7b14b19cbinto master 3 years agoReviewers
f7b14b19cb.