Adding version 14.0.13 #272

Merged
SlavekB merged 2 commits from feat/14.0.13 into master 2 years ago
Collaborator

Added version 14.0.13. Now available for assembly.

Added version 14.0.13. Now available for assembly.
ormorph added 1 commit 2 years ago
cc26a6f102
Fixing Kalarm Dependencies
SlavekB requested changes 2 years ago
SlavekB left a comment
Owner

Compared to files in live builds and R14.0.12, the # Copyright 1999-2022 Gentoo Authors line was omitted. Is this intentional or an oversight?

Besides that, there are a few small things to fix. See comments below.

Compared to files in live builds and R14.0.12, the `# Copyright 1999-2022 Gentoo Authors` line was omitted. Is this intentional or an oversight? Besides that, there are a few small things to fix. See comments below.
# Copyright 2022 The Trinity Desktop Project
Owner

Here in previous versions it was 1999-2022.

Here in previous versions it was `1999-2022`.
EAPI="8"
TRINITY_MODULE_NAME="tdeutils"
Owner

For R14.0.x branch there must be tdewebdev.

For R14.0.x branch there must be `tdewebdev`.
~trinity-base/ksim-${PV}
~trinity-base/ktimer-${PV}
~trinity-base/superkaramba-${PV}
~trinity-base/tdefilereplace-${PV}
Owner

For the R14.0.x branch, tdefilereplace is part of tdewebdev. Is it intended that for R14.0.13 it is listed in the tdeutils metapackage?

For the R14.0.x branch, `tdefilereplace` is part of `tdewebdev`. Is it intended that for R14.0.13 it is listed in the `tdeutils` metapackage?
ormorph force-pushed feat/14.0.13 from f37e6c4db1 to c68dd42531 2 years ago
Poster
Collaborator

Compared to files in live builds and R14.0.12, the # Copyright 1999-2022 Gentoo Authors line was omitted. Is this intentional or an oversight?

This is intentional, as the ebuild history of this version starts in 2022. In ebuilds of the live version, the entire history is preserved.
The rest has been corrected so far. But in principle, you can return this story, since these ebuilds are based on older ones.

> Compared to files in live builds and R14.0.12, the # Copyright 1999-2022 Gentoo Authors line was omitted. Is this intentional or an oversight? This is intentional, as the ebuild history of this version starts in 2022. In ebuilds of the live version, the entire history is preserved. The rest has been corrected so far. But in principle, you can return this story, since these ebuilds are based on older ones.
Owner

Compared to files in live builds and R14.0.12, the # Copyright 1999-2022 Gentoo Authors line was omitted. Is this intentional or an oversight?

This is intentional, as the ebuild history of this version starts in 2022. In ebuilds of the live version, the entire history is preserved.
The rest has been corrected so far. But in principle, you can return this story, since these ebuilds are based on older ones.

Ok, if this is customary in Gentoo, then I have no objection. From my point of view, the file is not created completely new, but a copy, which does not change the fact that it is the result of the author's work of previous authors in the original time period. That's why I thought it was right to keep the original copyright information there.

> > Compared to files in live builds and R14.0.12, the # Copyright 1999-2022 Gentoo Authors line was omitted. Is this intentional or an oversight? > > This is intentional, as the ebuild history of this version starts in 2022. In ebuilds of the live version, the entire history is preserved. > The rest has been corrected so far. But in principle, you can return this story, since these ebuilds are based on older ones. Ok, if this is customary in Gentoo, then I have no objection. From my point of view, the file is not created completely new, but a copy, which does not change the fact that it is the result of the author's work of previous authors in the original time period. That's why I thought it was right to keep the original copyright information there.
Poster
Collaborator

Ok, if this is customary in Gentoo, then I have no objection. From my point of view, the file is not created completely new, but a copy, which does not change the fact that it is the result of the author's work of previous authors in the original time period. That's why I thought it was right to keep the original copyright information there.

There are no problems with fixing these lines. It is enough to execute the script:

#!/bin/bash
fix_copyright() {
        echo "fix_copyright"
        while read file
        do
          	file2=${file/14.0.12/14.0.13}
                sed -e '/# Copyright/d' -i ${file2}
                i=0;
                cat ${file}|grep '# Copyright' | while read str
                do
                  	i=$((i+1))
                        sed "$i s/^/${str}\n/;" -i ${file2}
                done
        done <<<"$(find -name "*-14.0.12.ebuild")"
}

fix_copyright

It's probably best to return it.

> Ok, if this is customary in Gentoo, then I have no objection. From my point of view, the file is not created completely new, but a copy, which does not change the fact that it is the result of the author's work of previous authors in the original time period. That's why I thought it was right to keep the original copyright information there. There are no problems with fixing these lines. It is enough to execute the script: ``` #!/bin/bash fix_copyright() { echo "fix_copyright" while read file do file2=${file/14.0.12/14.0.13} sed -e '/# Copyright/d' -i ${file2} i=0; cat ${file}|grep '# Copyright' | while read str do i=$((i+1)) sed "$i s/^/${str}\n/;" -i ${file2} done done <<<"$(find -name "*-14.0.12.ebuild")" } fix_copyright ``` It's probably best to return it.
Owner

Ok, if this is customary in Gentoo, then I have no objection. From my point of view, the file is not created completely new, but a copy, which does not change the fact that it is the result of the author's work of previous authors in the original time period. That's why I thought it was right to keep the original copyright information there.

There are no problems with fixing these lines. It is enough to execute the script:

#!/bin/bash
fix_copyright() {
        echo "fix_copyright"
        while read file
        do
          	file2=${file/14.0.12/14.0.13}
                sed -e '/# Copyright/d' -i ${file2}
                i=0;
                cat ${file}|grep '# Copyright' | while read str
                do
                  	i=$((i+1))
                        sed "$i s/^/${str}\n/;" -i ${file2}
                done
        done <<<"$(find -name "*-14.0.12.ebuild")"
}

fix_copyright

It's probably best to return it.

Will you do this update?

> > Ok, if this is customary in Gentoo, then I have no objection. From my point of view, the file is not created completely new, but a copy, which does not change the fact that it is the result of the author's work of previous authors in the original time period. That's why I thought it was right to keep the original copyright information there. > > There are no problems with fixing these lines. It is enough to execute the script: > ``` > #!/bin/bash > fix_copyright() { > echo "fix_copyright" > while read file > do > file2=${file/14.0.12/14.0.13} > sed -e '/# Copyright/d' -i ${file2} > i=0; > cat ${file}|grep '# Copyright' | while read str > do > i=$((i+1)) > sed "$i s/^/${str}\n/;" -i ${file2} > done > done <<<"$(find -name "*-14.0.12.ebuild")" > } > > fix_copyright > ``` > It's probably best to return it. Will you do this update?
ormorph force-pushed feat/14.0.13 from c68dd42531 to 345c52699f 2 years ago
Poster
Collaborator

Will you do this update?

Already done.

> Will you do this update? Already done.
Poster
Collaborator

Ran ebuilds through pkgcheck, no errors. Everything was going with these dependencies. Only here there were no errors with tdefilereplace, since an empty package was assembled, and the assembly of other packages does not depend on it. I once corrected this package in ebuilds, but apparently I forgot it. The tdefilereplace package is needed for quanta to work, but the build does not depend on it.

Ran ebuilds through pkgcheck, no errors. Everything was going with these dependencies. Only here there were no errors with `tdefilereplace`, since an empty package was assembled, and the assembly of other packages does not depend on it. I once corrected this package in ebuilds, but apparently I forgot it. The `tdefilereplace` package is needed for `quanta` to work, but the build does not depend on it.
Owner

Ran ebuilds through pkgcheck, no errors. Everything was going with these dependencies. Only here there were no errors with tdefilereplace, since an empty package was assembled, and the assembly of other packages does not depend on it. I once corrected this package in ebuilds, but apparently I forgot it. The tdefilereplace package is needed for quanta to work, but the build does not depend on it.

Thank you, it looks good. Should I wait for the tdefilereplace problem to be fixed or merge it as it is?

> Ran ebuilds through pkgcheck, no errors. Everything was going with these dependencies. Only here there were no errors with `tdefilereplace`, since an empty package was assembled, and the assembly of other packages does not depend on it. I once corrected this package in ebuilds, but apparently I forgot it. The `tdefilereplace` package is needed for `quanta` to work, but the build does not depend on it. Thank you, it looks good. Should I wait for the tdefilereplace problem to be fixed or merge it as it is?
Poster
Collaborator

Should I wait for the tdefilereplace problem to be fixed or merge it as it is?

The problem with tdefilereplace has already been fixed. You can already merge it.

--- tdefilereplace-9999.ebuild	2022-10-28 19:42:55.394507891 +0200
+++ tdefilereplace-14.0.13.ebuild	2022-10-28 19:42:55.394507891 +0200
@@ -4,12 +4,12 @@
 
 EAPI="8"
 
-TRINITY_MODULE_NAME="tdeutils"
+TRINITY_MODULE_NAME="tdewebdev"
 TRINITY_MODULE_TYPE="core"
 TRINITY_HANDBOOK="optional"
 inherit trinity-meta-2
 
 DESCRIPTION="A batch search and replace tool for TDE"
 if [[ ${PV} != *9999* ]] ; then
-    KEYWORDS="~amd64 ~x86"
+    KEYWORDS="~amd64 ~arm64 ~x86"
 fi
> Should I wait for the tdefilereplace problem to be fixed or merge it as it is? The problem with tdefilereplace has already been fixed. You can already merge it. ``` --- tdefilereplace-9999.ebuild 2022-10-28 19:42:55.394507891 +0200 +++ tdefilereplace-14.0.13.ebuild 2022-10-28 19:42:55.394507891 +0200 @@ -4,12 +4,12 @@ EAPI="8" -TRINITY_MODULE_NAME="tdeutils" +TRINITY_MODULE_NAME="tdewebdev" TRINITY_MODULE_TYPE="core" TRINITY_HANDBOOK="optional" inherit trinity-meta-2 DESCRIPTION="A batch search and replace tool for TDE" if [[ ${PV} != *9999* ]] ; then - KEYWORDS="~amd64 ~x86" + KEYWORDS="~amd64 ~arm64 ~x86" fi ```
SlavekB approved these changes 2 years ago
SlavekB left a comment
Owner

Thank you for your good work. It looks good.

Thank you for your good work. It looks good.
SlavekB merged commit 345c52699f into master 2 years ago
SlavekB deleted branch feat/14.0.13 2 years ago
SlavekB added this to the R14.0.13 release milestone 2 years ago

Reviewers

SlavekB approved these changes 2 years ago
The pull request has been merged as 345c52699f.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-packaging-gentoo#272
Loading…
There is no content yet.