fixes pkgcheck output "UnderscoreInUseFlag" #359

pkgcheck scan:

trinity-apps/k3b
  UnderscoreInUseFlag: USE flag 'ffmpeg_all_codecs' uses reserved underscore character

That seems good to me. Only there is a question – see below.
Please, can you make rebase to the current head so that your GPG signatures can be preserved while merging?

I can't 'git push', there seems to be something wrong with my network.. please wait for a few minutes. I'm really sorry.

-f --force

I can't 'git push', there seems to be something wrong with my network.. please wait for a few minutes. I'm really sorry.

-f --force

yes i know there's '-f' flag.

All looks good.

If you're interested, here's the link.
We haven't used this yet, but anything can happen.

If you're interested, here's the link.
We haven't used this yet, but anything can happen.

I'm not really familiar with mailing lists so I'll just stick with Gitea for a while.

oops sorry i pressed the wrong button

All still looks good 😉

One more thing... it looks like somewhere between squashes you mangled copyright notices a bit: AFAIK you shouldn't remove the starting year...

One more thing... it looks like somewhere between squashes you mangled copyright notices a bit: AFAIK you shouldn't remove the starting year...

https://gitweb.gentoo.org/repo/gentoo.git/tree/header.txt

header.txt doesn't have the beginning year so i removed the beginning year too. should i keep it?

header.txt doesn't have the beginning year so i removed the beginning year too. should i keep it?

The header.txt file has nothing to do with it at all.
These are the years when this package began to be distributed, the top date is when in Gentoo, and the bottom date is when in TDE. You should know that this ebuild is based on earlier Gentoo ebuilds. These dates should be corrected and the start year should be present. I am attaching an old ebuild from Gentoo.
I wouldn’t touch this package at all, since although it’s going to be put together, it’s not working. When trying to read the disk information it just freezes.
You should keep an eye on the dates, as they are added for a reason.

k3b-1.0.5-r3.ebuild.gz

2.0 KiB

header.txt doesn't have the beginning year so i removed the beginning year too. should i keep it?

The header.txt file has nothing to do with it at all.
These are the years when this package began to be distributed, the top date is when in Gentoo, and the bottom date is when in TDE. You should know that this ebuild is based on earlier Gentoo ebuilds. These dates should be corrected and the start year should be present. I am attaching an old ebuild from Gentoo.
I wouldn’t touch this package at all, since although it’s going to be put together, it’s not working. When trying to read the disk information it just freezes.
You should keep an eye on the dates, as they are added for a reason.

sorry, i'll fix it

 # Copyright 1999-2020 Gentoo Authors
 # Copyright 2020 The Trinity Desktop Project
 # Copyright 1999-2023 Gentoo Authors
 # Copyright 2020-2023 The Trinity Desktop Project

fixes pkgcheck output "UnderscoreInUseFlag" #359

Reviewers