ARCH: Add krename PKGBUILD #161
Merged
SlavekB
merged 1 commits from InvertedRabbit/tde-packaging:master
into master
2 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'InvertedRabbit/tde-packaging:master'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Adds release PKGBUILD for tde-krename for Arch/pacman systems.
Thank you, it looks good.
There is one formal note: You need to use the
-s
option at the commit, which automatically adds theSigned-off-by
line to express your consent to Developer Certificate of Origin (DCO).The second note applies to your next contributions: Instead of forking, we prefer to use shared collaboration with branches model. I added you to the Contributors team so you could create a pull requests directly on the main repository. See wiki information about TGW.
@SlavekB Understood. Not very familiar with git so I'm still getting used to it.
Should I make a branch instead or just keep with the fork for this pull request? I'm not entirely sure how to move forward here.
For this PR, you can leave it as it is – PR from fork. The only thing to do is to update the commit comment to contain a
Signed-off-by
line. You can use:As soon as it is merged, you will be able to remove your fork and then use branch on the main repository for the future PR's.
a42904a4f8
to819647c1ab
2 years ago819647c1ab
tofca2eccc37
2 years agoAdded the
Signed-off-by
line, I think.Yes, great, the
Signed-off-by
line was added well.The only little note – for a better overview in
tde-packaging
repository there it would be good for the commit comment to start with the prefixArchLinux: ...
orArchLinux krename: ...
, as you can see in similar commits. Can I ask you for this adjustment?fca2eccc37
tod420221474
2 years agoHows this?
Great, it looks good.
497a88a0bf
into master 2 years agoReviewers
497a88a0bf
.