ARCH: Add krename PKGBUILD #161

Merged
SlavekB merged 1 commits from InvertedRabbit/tde-packaging:master into master 2 years ago
Collaborator

Adds release PKGBUILD for tde-krename for Arch/pacman systems.

Adds release PKGBUILD for tde-krename for Arch/pacman systems.
Owner

Thank you, it looks good.

There is one formal note: You need to use the -s option at the commit, which automatically adds the Signed-off-by line to express your consent to Developer Certificate of Origin (DCO).

The second note applies to your next contributions: Instead of forking, we prefer to use shared collaboration with branches model. I added you to the Contributors team so you could create a pull requests directly on the main repository. See wiki information about TGW.

Thank you, it looks good. There is one formal note: You need to use the `-s` option at the commit, which automatically adds the `Signed-off-by` line to express your consent to [Developer Certificate of Origin (DCO)](https://developercertificate.org/). The second note applies to your next contributions: Instead of forking, we prefer to use shared collaboration with branches model. I added you to the Contributors team so you could create a pull requests directly on the main repository. See [wiki information about TGW](https://wiki.trinitydesktop.org/TDE_Gitea_Workspace#To_contribute_code_changes).
Poster
Collaborator

@SlavekB Understood. Not very familiar with git so I'm still getting used to it.

Should I make a branch instead or just keep with the fork for this pull request? I'm not entirely sure how to move forward here.

@SlavekB Understood. Not very familiar with git so I'm still getting used to it. Should I make a branch instead or just keep with the fork for this pull request? I'm not entirely sure how to move forward here.
Owner

For this PR, you can leave it as it is – PR from fork. The only thing to do is to update the commit comment to contain a Signed-off-by line. You can use:

git commit -s --amend
git push -f origin HEAD

As soon as it is merged, you will be able to remove your fork and then use branch on the main repository for the future PR's.

For this PR, you can leave it as it is – PR from fork. The only thing to do is to update the commit comment to contain a `Signed-off-by` line. You can use: git commit -s --amend git push -f origin HEAD As soon as it is merged, you will be able to remove your fork and then use branch on the main repository for the future PR's.
InvertedRabbit force-pushed master from a42904a4f8 to 819647c1ab 2 years ago
InvertedRabbit force-pushed master from 819647c1ab to fca2eccc37 2 years ago
Poster
Collaborator

Added the Signed-off-by line, I think.

Added the `Signed-off-by` line, I think.
Owner

Added the Signed-off-by line, I think.

Yes, great, the Signed-off-by line was added well.

The only little note – for a better overview in tde-packaging repository there it would be good for the commit comment to start with the prefix ArchLinux: ... or ArchLinux krename: ..., as you can see in similar commits. Can I ask you for this adjustment?

> Added the `Signed-off-by` line, I think. Yes, great, the `Signed-off-by` line was added well. The only little note – for a better overview in `tde-packaging` repository there it would be good for the commit comment to start with the prefix `ArchLinux: ...` or `ArchLinux krename: ...`, as you can see in similar commits. Can I ask you for this adjustment?
InvertedRabbit force-pushed master from fca2eccc37 to d420221474 2 years ago
Poster
Collaborator

Hows this?

Hows this?
SlavekB approved these changes 2 years ago
SlavekB left a comment
Owner

Great, it looks good.

Great, it looks good.
SlavekB merged commit 497a88a0bf into master 2 years ago
SlavekB added this to the R14.1.0 release milestone 2 years ago

Reviewers

SlavekB approved these changes 2 years ago
The pull request has been merged as 497a88a0bf.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-packaging#161
Loading…
There is no content yet.