DEB pytqt: drop python2 support. #176
Merged
MicheleC
merged 1 commits from deb/python-tqt/drop-python2 into master 1 year ago
No Label
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Depends on
#175 DEB sip4-tqt: drop python2 support.
TDE/tde-packaging
Reference: TDE/tde-packaging#176
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'deb/python-tqt/drop-python2'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Requires PR #175.
Local test of examples with python 3 works fine.
One question is whether to rename the packages
python-tqt-{dev,doc}intopython3-tqt-{dev,doc}(with the 3 in the name like other packages).Like for sip4-tqt, the second commit suggests names that should make the migration easier from both R14.0.x and R14.1.0-dev.
Commits to be squashed before merging.
411d3cddf9to7e6633b2971 year agoPR further updated following changes on sip4-tqt PR
There are some small things to solve – see comments.
XSBC-Original-Maintainer: Debian Python Modules Team <python-modules-team@lists.alioth.debian.org>Uploaders: Torsten Marek <shlomme@debian.org>, Bernd Zeimetz <bzed@debian.org>, Michael Casadevall <mcasadevall@debian.org>Build-Depends: debhelper (>= 9~), python-all-dev (>= 2.3.5-10), python-all-dbg, python3-all-dev, python3-all-dbg, libtqtinterface-dev, tqt3-dev-tools, tqt3-apps-dev, python3-sip-tqt-dev, python3-sip-tqt-dbg, python-sip-tqt-dev, python-sip-tqt-dbg, libtqscintilla-dev, python-support (>= 0.7.1) | dh-pythonBuild-Depends: debhelper (>= 9~), python3-all-dev, python3-all-dbg, libtqtinterface-dev, tqt3-dev-tools, tqt3-apps-dev, python3-sip-tqt-dev, sip-tqt-dev, python3-sip-tqt-dbg, libtqscintilla-dev, dh-pythonsip-tqt-devdoes not need to be listed as it is a required dependency forpython3-sip-tqt-dev.Ok, makes sense.
Package: python3-tqtArchitecture: anyDepends: ${shlibs:Depends}, ${python3:Depends}, ${sip3-tqt:Depends}, ${misc:Depends}${py3sip-tqt:Depends}should be used here instead of${sip3-tqt:Depends}to ensure a dependency on the corresponding API version of SIP-TQt – see change ofdh_py3sip_tqtin #175.Good catch, I missed that.
Linguist translation files from Python code.Package: python-tqt-devThe question arises whether to keep the names
python-tqt-devandpython-tqt-doc, which may give the impression of a dependency on Python 2, or whether to shorten the package names topytqt-devandpytqt-docwhen we consider using PyTQt as the source name?I suggest we do this when we actually rename the repository. What do you think?
Yes, we can consider renaming the source package and also git repository. In any case, you may notice that the
pytqt-toolsbinary package is already being built in this package, so it's not the first binary package with a name in this format.How about renaming the packages as follow?
Yes, that makes sense. At the same time, however, we should probably go one step further and rename the python module as such from
python_tqttoPyTQt.Yes, good idea.
package names updated in 2nd commit. When all good, we can squash them.
7e6633b297todcc725f4de1 year agoPR updated as per feedback
XSBC-Original-Maintainer: Debian Python Modules Team <python-modules-team@lists.alioth.debian.org>Uploaders: Torsten Marek <shlomme@debian.org>, Bernd Zeimetz <bzed@debian.org>, Michael Casadevall <mcasadevall@debian.org>Build-Depends: debhelper (>= 9~), python-all-dev (>= 2.3.5-10), python-all-dbg [!solaris-any], python3-all-dev, python3-all-dbg [!solaris-any], libtqtinterface-dev, tqt3-dev-tools, tqt3-apps-dev, python3-sip-tqt-dev, python3-sip-tqt-dbg, python-sip-tqt-dev, python-sip-tqt-dbg [!solaris-any], libtqscintilla-dev, python-support (>= 0.7.1) | dh-pythonBuild-Depends: debhelper (>= 9~), python3-all-dev, python3-all-dbg [!solaris-any], libtqtinterface-dev, tqt3-dev-tools, tqt3-apps-dev, python3-sip-tqt-dev, python3-sip-tqt-dbg, libtqscintilla-dev, dh-pythonNote: For
-dbgpackages in DilOS is used[!solaris-any]. So it should be used for the packagepython3-sip-tqt-dbgas well.Ah, my bad. Somehow I had overwritten that unintentionally. Fixed.
Actually I checked the code in master and the
[!solaris-any]was missing frompython3-sip-tqt-dbgin first place :-)thanks for correcting my earlier mistake :)
dcc725f4detodedcd090591 year agodedcd09059tode3998cda41 year agode3998cda4to0edfaf2f431 year ago0edfaf2f43toe083d551c11 year agoRebased to the current head. The second (temporary) commit is no longer needed because the renaming was done in the previous one.
Nice, thanks for updating this. I was planning to do it myself but nice to find the job done already ;-)
e083d551c1to6b383d62221 year agoThere was one more change required in debian/rules which was causing FTBFS. Commit updated.
6b383d6222to3b5942e7b31 year agoEverything looks good.
DEB python-tqt: drop python2 support.to WIP: (READY) DEB python-tqt: drop python2 support. 1 year ago3b5942e7b3to61555e4f9e1 year ago61555e4f9etof72276dd661 year agof72276dd66tof963f7aac51 year agoWIP: (READY) DEB python-tqt: drop python2 support.to DEB python-tqt: drop python2 support. 1 year agoDEB python-tqt: drop python2 support.to WIP: DEB python-tqt: drop python2 support. 1 year agoWIP: DEB python-tqt: drop python2 support.to DEB python-tqt: drop python2 support. 1 year agof963f7aac5into master 1 year agoDEB python-tqt: drop python2 support.to DEB pytqt: drop python2 support. 1 year agoReviewers
f963f7aac5.