DEB arts: Change the library package name in case of incompatible ABI for 64-bit time_t. #284

Merged
SlavekB merged 1 commits from deb/t64abi/arts into master 2 months ago
Owner

Added a build-time change of libarts1c2a package to libarts1t64, for distributions and architectures that enforce 64-bit time_t. Because historically there was a suffix c2a as a result of earlier ABI migrations, it is replaced by t64.

Added a build-time change of `libarts1c2a` package to `libarts1t64`, for distributions and architectures that enforce 64-bit `time_t`. Because historically there was a suffix `c2a` as a result of earlier ABI migrations, it is replaced by `t64`.
SlavekB added 1 commit 2 months ago
SlavekB added this to the R14.1.2 release milestone 2 months ago
SlavekB requested review from Owners 2 months ago
SlavekB requested review from Packagers 2 months ago
MicheleC reviewed 2 months ago
Replaces: arts-trinity (<< 4:14.0.0~)
Breaks: arts-trinity (<< 4:14.0.0~)
Depends: libartsc0-trinity (>= ${source:Version}), libarts1c2a-trinity (>= ${source:Version})
Depends: libartsc0-trinity (>= ${source:Version}), libarts1c2a-trinity (>= ${source:Version}) | libarts1t64-trinity (>= ${source:Version})
Owner

As per comment in another PR, it would be better to modify the Depends field at run time for -t64 packages, IMO.

As per comment in another PR, it would be better to modify the `Depends` field at run time for -t64 packages, IMO.
Poster
Owner

See explanation in comment on #283.

See explanation in comment on [#283](https://mirror.git.trinitydesktop.org/gitea/TDE/tde-packaging/pulls/283#issuecomment-45288).
MicheleC marked this conversation as resolved
MicheleC reviewed 2 months ago
DEB_DH_STRIP_ARGS := --dbg-package=arts-trinity-dbg
PACKAGES_WITH_LIBS := libarts1c2a-trinity libartsc0-trinity
PACKAGES_WITH_LIBS := libarts1$(DEB_TIME64_SUFFIX)-trinity libartsc0-trinity
Owner

It would also be good to keep the same root name libarts1c2a for the t64 package. For R14.2.0 we could discuss about dropping the c2a part, like was done long ago for tdelibs

It would also be good to keep the same root name `libarts1c2a` for the t64 package. For R14.2.0 we could discuss about dropping the `c2a` part, like was done long ago for tdelibs
Poster
Owner

Suffix removal is possible in two cases: the SO version changes, which was the case of tdelibs – tdelibs3c2a was changed to tdelibs14, or the suffix turns into another, which is case of t64. You can see this information about the removal of the original suffixes and replace with the t64 on https://wiki.debian.org/releasegoals/64bit-time

In this case, there was no reason to increase the version of SO, so there was no opportunity to remove the suffix, but only the opportunity to replace it. Remember that the increase in the SO version on the removal or replacement of the suffix means the need to rebuild all dependent packages.

Suffix removal is possible in two cases: the _SO version_ changes, which was the case of tdelibs – `tdelibs3c2a` was changed to `tdelibs14`, or the suffix turns into another, which is case of `t64`. You can see this information about the removal of the original suffixes and replace with the `t64` on https://wiki.debian.org/releasegoals/64bit-time In this case, there was no reason to increase the version of SO, so there was no opportunity to remove the suffix, but only the opportunity to replace it. Remember that the increase in the SO version on the removal or replacement of the suffix means the need to rebuild all dependent packages.
SlavekB force-pushed deb/t64abi/arts from e83caeb51c to 8f8ece8a19 2 months ago
MicheleC approved these changes 2 months ago
MicheleC left a comment
Owner

Looks good

Looks good
SlavekB merged commit 8f8ece8a19 into master 2 months ago
SlavekB deleted branch deb/t64abi/arts 2 months ago

Reviewers

MicheleC approved these changes 2 months ago
TDE/Packagers was requested for review 2 months ago
The pull request has been merged as 8f8ece8a19.
Sign in to join this conversation.
No reviewers
TDE/Packagers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-packaging#284
Loading…
There is no content yet.