some cleanup #6

Merged

MicheleC merged 3 commits from fix/some_cleanup into master

Ghost commented

There is no content yet.

Ghost added the PR/wip label

Ghost added 1 commit

4da1cf518a

Signed-off-by: gregory guy <gregory-tde@laposte.net>

Ghost added 1 commit

a43de583f2

Signed-off-by: gregory guy <gregory-tde@laposte.net>

Ghost force-pushed fix/some_cleanup from a43de583f2 to 6216a7aa09

Ghost added 1 commit

71285e7739

Signed-off-by: gregory guy <gregory-tde@laposte.net>

Ghost changed title from ~~WIP:Add headers to UI files to prevent potential FTBFS.~~ to some cleanup

Ghost removed the PR/wip label

MicheleC requested changes

MicheleC left a comment

Owner

It looks good other than for one thing to fix.

style/polish.cpp Outdated

MicheleC commented

Owner

#if !KDE_IS_VERSION(3,4,3) fails since it is a negated check, so I think we should remove the line

	    if (!(w->parent() && w->parent()->inherits("MiniBar")))

MicheleC marked this conversation as resolved

Ghost force-pushed fix/some_cleanup from 71285e7739 to 610b0fea26

MicheleC approved these changes

MicheleC left a comment

Owner

Looks good now.

MicheleC merged commit 610b0fea26 into master 3 years ago

MicheleC deleted branch fix/some_cleanup

MicheleC added this to the R14.0.11 release milestone

MicheleC approved these changes

The pull request has been merged as 610b0fea26.

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-style-baghira#6