@SlavekB when you've got time can you have a look into the symbols visibility?
There seems to be no need for any additional care regarding hidden visibility, as the result is a standalone application without additional libraries and modules.
> @SlavekB when you've got time can you have a look into the symbols visibility?
There seems to be no need for any additional care regarding hidden visibility, as the result is a standalone application without additional libraries and modules.
These are also desktop style files for which we will want to use desktop file translation using TWTW. Therefore, it is also possible to use tde_create_translated_desktop here.
These are also desktop style files for which we will want to use desktop file translation using TWTW. Therefore, it is also possible to use `tde_create_translated_desktop` here.
These are also desktop style files for which we will want to use desktop file translation using TWTW. Therefore, it is also possible to use tde_create_translated_desktop here.
These are also desktop style files for which we will want to use desktop file translation using TWTW. Therefore, it is also possible to use `tde_create_translated_desktop` here.
Fixed and added the use of tde_create_translated_desktop.
Added commit to resolve ascii-cast.
The first step of moving translations to a new layout has been performed.
+ Fixed and added the use of tde_create_translated_desktop.
+ Added commit to resolve ascii-cast.
+ The first step of moving translations to a new layout has been performed.
I wanted to move forward and merge it, because everything looks good, but subsequently I noticed that in tde-packaging for Debian there is a man page. Will you add it to the main tree?
I wanted to move forward and merge it, because everything looks good, but subsequently I noticed that in tde-packaging for Debian there is a man page. Will you add it to the main tree?
One more note: Because the project name is set to tde-systemsettings, the translation catalogs are now installed as tde-systemsettings.mo.
This is basically not a problem – on the contrary, it can be an advantage that it is not a very common name. However, there will need to be an adjustment in systemsettings/main.cpp for TDELocale::setMainCatalogue(...) to set tde-systemsettings instead of the current systemsettings.
What is your opinion – keep the new name of the catalog or revert to the previous one?
One more note: Because the project name is set to `tde-systemsettings`, the translation catalogs are now installed as `tde-systemsettings.mo`.
This is basically not a problem – on the contrary, it can be an advantage that it is not a very common name. However, there will need to be an adjustment in `systemsettings/main.cpp` for `TDELocale::setMainCatalogue(...)` to set `tde-systemsettings` instead of the current `systemsettings`.
What is your opinion – keep the new name of the catalog or revert to the previous one?
What is your opinion – keep the new name of the catalog or revert to the previous one?
Looks to me that a thorough job should change the name/ocurrence: systemsettings vs tde-systemsettings everywhere in this module; namely code, config and desktop files alike, help and man page...
It shouldn't be difficult but time consumming and I don't feel like doing It. 😩
> What is your opinion – keep the new name of the catalog or revert to the previous one?
Looks to me that a thorough job should change the name/ocurrence: **systemsettings** vs **tde-systemsettings** everywhere in this module; namely code, config and desktop files alike, help and man page...
It shouldn't be difficult but time consumming and I don't feel like doing It. :weary:
What is your opinion – keep the new name of the catalog or revert to the previous one?
Looks to me that a thorough job should change the name/ocurrence: systemsettings vs tde-systemsettings everywhere in this module; namely code, config and desktop files alike, help and man page...
It shouldn't be difficult but time consumming and I don't feel like doing It. 😩
Ok, that's not a problem – we can move the translations to be installed as systemsettings.mo, as it was before.
> > What is your opinion – keep the new name of the catalog or revert to the previous one?
>
> Looks to me that a thorough job should change the name/ocurrence: **systemsettings** vs **tde-systemsettings** everywhere in this module; namely code, config and desktop files alike, help and man page...
> It shouldn't be difficult but time consumming and I don't feel like doing It. :weary:
Ok, that's not a problem – we can move the translations to be installed as `systemsettings.mo`, as it was before.
SlavekB
于 4 年前 修改标题 WIP:Conversion to the cmake building system. 为 Conversion to the cmake building system.
@SlavekB when you've got time can you have a look into the symbols visibility?
There seems to be no need for any additional care regarding hidden visibility, as the result is a standalone application without additional libraries and modules.
It looks good. Here are some small comments.
##### other data
install(
These are also desktop style files for which we will want to use desktop file translation using TWTW. Therefore, it is also possible to use
tde_create_translated_desktop
here.DESTINATION ${XDG_APPS_INSTALL_DIR}
)
install(
These are also desktop style files for which we will want to use desktop file translation using TWTW. Therefore, it is also possible to use
tde_create_translated_desktop
here.Note: I have a patch for ascii-cast ready – it's single line.
the desktop files installation have been added to the cmake conversion.
I wanted to move forward and merge it, because everything looks good, but subsequently I noticed that in tde-packaging for Debian there is a man page. Will you add it to the main tree?
One more note: Because the project name is set to
tde-systemsettings
, the translation catalogs are now installed astde-systemsettings.mo
.This is basically not a problem – on the contrary, it can be an advantage that it is not a very common name. However, there will need to be an adjustment in
systemsettings/main.cpp
forTDELocale::setMainCatalogue(...)
to settde-systemsettings
instead of the currentsystemsettings
.What is your opinion – keep the new name of the catalog or revert to the previous one?
Man page added, please test.
Looks to me that a thorough job should change the name/ocurrence: systemsettings vs tde-systemsettings everywhere in this module; namely code, config and desktop files alike, help and man page...
It shouldn't be difficult but time consumming and I don't feel like doing It. 😩
Excellent, tested, everything is fine.
Ok, that's not a problem – we can move the translations to be installed as
systemsettings.mo
, as it was before.WIP:Conversion to the cmake building system.为 Conversion to the cmake building system.b3a20cdb91
到 masterb3a20cdb91
被合并。