TDE
/
tdebase
9
3
Fork 1
Code Issues 119 Pull Requests 10 Releases Wiki Activity
Labels Milestones
New Issue

Rename twin3 to twin for window decoration libraries #351

Closed
opened 12 months ago by blu.256 · 3 comments
blu.256 commented 12 months ago
Collaborator

I think this is consistent with the strategy for R14.2.0. IMO there is no point in keeping the '3' part in window decoration libraries, especially considering that corresponding config libraries do not have it.

What will need to changed:

I think this is consistent with the strategy for R14.2.0. IMO there is no point in keeping the '3' part in window decoration libraries, especially considering that corresponding config libraries do not have it. What will need to changed: * https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/src/commit/f885561fda56d3b6eb47b1979a547b49a00954a2/twin/kcmtwin/twindecoration/twindecoration.cpp#L417 * CMakeLists.txt and .desktop files in all window decorations (or we could keep compatibility with the 'twin3' variant)
blu.256 added this to the R14.2.0 release milestone 12 months ago
blu.256 added the PR/rfc label 12 months ago
blu.256 changed title from Rename twin3 to twin to Rename twin3 to twin for window decoration libraries 12 months ago
MicheleC commented 12 months ago
Owner

I remember discussing this long ago with @SlavekB.
I also think keeping the 3 does not make much sense.

I remember discussing this long ago with @SlavekB. I also think keeping the 3 does not make much sense.
blu.256 referenced this issue from a commit 11 months ago
Make TWin look for `twin_` libraries
blu.256 referenced this issue from a commit 11 months ago
Make TWin look for `twin_` libraries
blu.256 removed the PR/rfc label 11 months ago
blu.256 referenced this issue from a commit 11 months ago
Make TWin look for `twin_` libraries
blu.256 referenced this issue from a commit 10 months ago
Make TWin look for `twin_` libraries
blu.256 commented 10 months ago
Poster
Collaborator

Done with TDE/tdebase#364 and related PRs.

Done with TDE/tdebase#364 and related PRs.
blu.256 closed this issue 10 months ago
MicheleC commented 10 months ago
Owner

Related PRs:

Related PRs: - [x] TDE/tdebase#364 - [x] TDE/tdebase#372 - [x] TDE/tdeartwork#22 - [x] TDE/twin-style-suse2#6 - [x] TDE/twin-style-crystal#4 - [x] TDE/twin-style-machbunt#4 - [x] TDE/twin-style-dekorator#3 - [x] TDE/tde-style-baghira#10 - [x] TDE/tde-style-ia-ora#3 - [x] TDE/tde-style-domino#3
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
r14.1.x
master
fix/kxkb-450
feat/shutdownd-dialog-border
feat/whatever
feat/kdesktop
feat/layouts
issue/270/tdebase
r14.0.x
v3.5.13-sru
issue/227
fix/kicker-clock-build-dependency
feat/pkg-config
branding/kde_to_tde2
feat/fix-suspend-code
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.2.0 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#351
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes