twin3_* to twin_* #364

This PR changes the way that TWin decoration libraries are called, dropping the '3' as discussed in #351.

Compatibility with the twin3_ scheme is maintained, but all the decorations are preferred to use the new scheme.

It looks good. I was afraid it would be a bigger problem, but this looks like a smooth change.

The changes look good but there are several other instances of "twin3_" left in tdebase. Some are just in Makefiles.am, so not so critical (but good to update too), but others are in xml files or cpp code related to plugins, so not sure it would affect functionality somewhere.
I think we should address all of them since we are doing the twin3 --> twin renaming.

I'll make the requested changes and it probably makes sense to do the same with window decorations in other repos (tdeaddons and standalone).

Great, sounds good.

The changes look good but there are several other instances of "twin3_" left in tdebase. Some are just in Makefiles.am, so not so critical (but good to update too), but others are in xml files or cpp code related to plugins, so not sure it would affect functionality somewhere.

Done. Didn't test the Makefiles, though they should probably work.

Will try to find time to test it tomorrow and feedback (very busy week :-( )

Nice catch in removing the files twin3_plugin.{pl,upd}.
I did not have enough time for a full test and to prepare a debian packaging PR too. Will do that tomorrow.

Looks good

@blu.256 please wait for TDE/tde-packaging#237 to be approved by Slavek, then merge this PR and subsequently that one as well (make sure to rebase it if necessary)

@MicheleC I've made the needed changes to all window decorations I could remember of:

Let me know if it's okay to merge them.

Let me know if it's okay to merge them.

I will approve on those PRs as I go through

Now I realized – we will not need an update script that existing twin3_ in users configuration will rewrite to twin_?

Now I realized – we will not need an update script that existing twin3_ in users configuration will rewrite to twin_?

Good point, we will need something like that because the theme will contain the name of the theme in it, which will change from twin3 to twin.
So it seems we have to add a conversion into r14-xdg-update

Now I realized – we will not need an update script that existing twin3_ in users configuration will rewrite to twin_?

That should not be necessary, as old twin3_ values still work for compatibility reasons and they will get overwritten the next time the user changes the used window decoration.

That should not be necessary, as old twin3_ values still work for compatibility reasons and they will get overwritten the next time the user changes the used window decoration.

I fear at the next reboot the theme will not be found if the theme is not updated (which is not something a user would do often anyway). Look at the contents of a .kth file under the wm section.
For example <wm type="builtin" name="twin3_SUSE2" > but now the name of the theme is twin_SUSE2 so probably it would not be loaded correctly.

Now I realized – we will not need an update script that existing twin3_ in users configuration will rewrite to twin_?

That should not be necessary, as old twin3_ values still work for compatibility reasons and they will get overwritten the next time the user changes the used window decoration.

If the user has twin3_ in its configuration, but actually there will be twin_ on the disk, will it work? I assumed it wouldn't work. It does not seem to be KDecorationPlugins::loadPlugin(...) is ready for something like that.

If the user has twin3_ in its configuration, but actually there will be twin_ on the disk, will it work? I assumed it wouldn't work. It does not seem to be KDecorationPlugins::loadPlugin(...) is ready for something like that.

I don't think there would be problems as the code can find libraries with both names but we can add an update script just to be sure.

Yes, the code is looking for libraries of both names. But after updating the packages, the user will have twin3_b2 in the configuration, while on the disk will be twin_b2. So twin3_b2 listed in the configuration will not be found => the default will be used.

See PR #372 for the renaming script.

twin3_* to twin_* #364

Reviewers