Improve initial desktop icons. #96

Merged
SlavekB merged 1 commits from fix/initicons into master 4 years ago
Chris commented 5 years ago
Collaborator

The comment section is used to display some description at the desktop in the "type" field.

To test it, or get it working, you have most likely to deactivate the specific icon in the desktop settings first and than activate it again. Otherwise, the old version will be preserved.

Would be wonderful if you could add the missing translations for your language, if you have time.

  • bg
  • cs
  • de
  • es
  • fr
  • it
  • ru

Signed-off-by: Chris xchrisx@uber.space

The comment section is used to display some description at the desktop in the "type" field. To test it, or get it working, you have most likely to deactivate the specific icon in the desktop settings first and than activate it again. Otherwise, the old version will be preserved. Would be wonderful if you could add the missing translations for your language, if you have time. + [x] bg + [x] cs + [x] de + [x] es + [x] fr + [x] it + [x] ru Signed-off-by: Chris <xchrisx@uber.space>
Owner

Done for me – Czech comments added 😸

Done for me – Czech comments added :smile_cat:
Chris commented 5 years ago
Poster
Collaborator

Thank you! 👍

Thank you! :+1:
Owner

The French translation needs to be fixed because it is not in utf8, but in single-byte encoding.

The French translation needs to be fixed because it is not in utf8, but in single-byte encoding.
Owner

Italian comments added too

Italian comments added too
Chris commented 4 years ago
Poster
Collaborator

Thank you, Michele. The missing RU and ES translations will be added by a commit of Vitaly (Vita_Cell in IRC) in the next days or week, if GIT works for him. Otherwise I will add them for him. 👍

Thank you, Michele. The missing RU and ES translations will be added by a commit of Vitaly (Vita_Cell in IRC) in the next days or week, if GIT works for him. Otherwise I will add them for him. :+1:
Collaborator

I would like to help fix the French translation.

I would like to help fix the French translation.
Chris commented 4 years ago
Poster
Collaborator

@robertpeters9, just add them here as a comment, if you like.

I think there is/was just some encoding problem for them or something like that.

@robertpeters9, just add them here as a comment, if you like. I think there is/was just some encoding problem for them or something like that.
Collaborator

I would like to help fix the French translation. Please excuse my ignorance as I am new to Gitea. Looks like I have to get the current file, change it to UTF8 encoding (2-byte), then upload it to somewhere.

I would like to help fix the French translation. Please excuse my ignorance as I am new to Gitea. Looks like I have to get the current file, change it to UTF8 encoding (2-byte), then upload it to somewhere.
Chris commented 4 years ago
Poster
Collaborator

No, that's no ignorance, you are very welcome to contribute, exactly the way as everyone and you can learn to do that, there is no problem. 😄

Do you know about GIT already in general? You need to fetch tdebase repo, and needs to be a contributor, which can be done by Slavek, if you want to contribute or translate further for FR. But I don't know if that is now the right way to start, because R14.0.7 will be freezed shortly. You can take a look at this:

https://wiki.trinitydesktop.org/TDE_Gitea_Workspace

Just clone tdebase, checkout the branch name of this PR, make your change to that file and commit it, but please don't forget to add "-s" to that commit, as described.

No, that's no ignorance, you are very welcome to contribute, exactly the way as everyone and you can learn to do that, there is no problem. :smile: Do you know about GIT already in general? You need to fetch tdebase repo, and needs to be a contributor, which can be done by Slavek, if you want to contribute or translate further for FR. But I don't know if that is now the right way to start, because R14.0.7 will be freezed shortly. You can take a look at this: https://wiki.trinitydesktop.org/TDE_Gitea_Workspace Just clone tdebase, checkout the branch name of this PR, make your change to that file and commit it, but please don't forget to add "-s" to that commit, as described.
Owner

@robertpeters9 now you are a member of the Contributors team – welcome! So you can now create branches and pull requests as described in the wiki.

@robertpeters9 now you are a member of the Contributors team – welcome! So you can now create branches and pull requests as described in the wiki.
Owner

I would like to help fix the French translation. Please excuse my ignorance as I am new to Gitea. Looks like I have to get the current file, change it to UTF8 encoding (2-byte), then upload it to somewhere.

Incidentally, it seems to me that the encoding of the French commit is fine – in utf8 encoding.

> I would like to help fix the French translation. Please excuse my ignorance as I am new to Gitea. Looks like I have to get the current file, change it to UTF8 encoding (2-byte), then upload it to somewhere. Incidentally, it seems to me that the encoding of the French commit is fine – in utf8 encoding.
Chris commented 4 years ago
Poster
Collaborator

@robertpeters9 your contribution in further times, like translations for FR, for example are very welcome in future anyway, because we often have need for that. So it's good to see you as new contributor now - Welcome. 😄

@robertpeters9 your contribution in further times, like translations for FR, for example are very welcome in future anyway, because we often have need for that. So it's good to see you as new contributor now - Welcome. :smile:
Collaborator

Thanks to Chris and SlavekB!
Following https://wiki.trinitydesktop.org/TDE_Gitea_Workspace, I cloned the complete TDE code. At least, the directory structure. Looks like the code is packed into the ~/TDE/tde/.git/objects/pack folder. I'll start looking into that.

Thanks to Chris and SlavekB! Following https://wiki.trinitydesktop.org/TDE_Gitea_Workspace, I cloned the complete TDE code. At least, the directory structure. Looks like the code is packed into the ~/TDE/tde/.git/objects/pack folder. I'll start looking into that.
Chris reviewed 4 years ago
Chris commented 4 years ago
Poster
Collaborator

I just noticed, that this one is still missing. Would be very nice if someone could add that.

I just noticed, that this one is still missing. Would be very nice if someone could add that.
Chris commented 4 years ago
Poster
Collaborator

This should be completed now. Please, by chance, just see over it again, otherwise it can be merged.

Thanks for all help. 👍

This should be completed now. Please, by chance, just see over it again, otherwise it can be merged. Thanks for all help. :+1:
Owner

It seems to me to be okay and ready for merge.

I rebase it to the current HEAD.

It seems to me to be okay and ready for merge. <br/>I rebase it to the current HEAD.
Chris closed this pull request 4 years ago
SlavekB closed this pull request 4 years ago
SlavekB deleted branch fix/initicons 4 years ago
SlavekB added this to the R14.0.7 release milestone 4 years ago
The pull request has been merged as f076b15382.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#96
Loading…
There is no content yet.