Labels Milestones

Fix duplicated, missing and misleading icons. #109

Merged

SlavekB merged 1 commits from fix/konqicons into master 4 years ago

Conversation 0 Commits 1 Files Changed 7

Chris commented 4 years ago

Collaborator

Finding some perfect icon for Java & JS is a bit hard, because while back in time that combination made sense, today I don't think we will find some better icon, if we want to let that config module a combination of that two.

Xinerama module was using the identity icon, which was all but related. So using the generic screen icon is a bit better.

I don't like to use MIME icons, but that is in that way more consistent as the font module is also using this kind of icon and it's better than some duplication.

For CGI programs/scripts, I think that is fine, otherwise I am open for input.

About appearance: That icon is used for mutiple other appearance modules, like for Kopete and so on. So using that is at least consistent with the most of TDE.

The shellcmdplugin was using some icon which was not existing at all - The result was a missing icon, so I used the console icon here.

Signed-off-by: Chris xchrisx@uber.space

Finding some perfect icon for Java & JS is a bit hard, because while back in time that combination made sense, today I don't think we will find some better icon, if we want to let that config module a combination of that two. Xinerama module was using the identity icon, which was all but related. So using the generic screen icon is a bit better. I don't like to use MIME icons, but that is in that way more consistent as the font module is also using this kind of icon and it's better than some duplication. For CGI programs/scripts, I think that is fine, otherwise I am open for input. About appearance: That icon is used for mutiple other appearance modules, like for Kopete and so on. So using that is at least consistent with the most of TDE. The shellcmdplugin was using some icon which was not existing at all - The result was a missing icon, so I used the console icon here. Signed-off-by: Chris <xchrisx@uber.space>

SlavekB closed this pull request 4 years ago

SlavekB deleted branch fix/konqicons 4 years ago

SlavekB added this to the R14.0.7 release milestone 4 years ago

The pull request has been merged as af4fd07d14.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce

No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme

Milestone

Set milestone

Clear milestone

No items

No Milestone

R14.0.7 release

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#109

Write Preview

Loading…

Cancel

Save

There is no content yet.