TDE
/
tdebase
9
4
Fork 1
Code Issues 116 Pull Requests 10 Releases Wiki Activity
Labels Milestones

relates to bug 2618 #12

Merged
MicheleC merged 3 commits from bug/2618/renameIcon into master 6 years ago
Conversation 7 Commits 3 Files Changed 9
Ghost commented 6 years ago

Some icons should be renamed tde*

Some icons should be renamed tde*
Ghost added the PR/wip label 6 years ago
MicheleC commented 6 years ago
Owner

Looks good to me. Can I merge or do you want to do more work on this? I see it is marked as WIP.

Looks good to me. Can I merge or do you want to do more work on this? I see it is marked as WIP.
Ghost commented 6 years ago
Poster

there's some more to come...

there's some more to come...
Ghost commented 6 years ago
Poster

There's an occurrence of kdelogo in:

doc/tdm/index.docbook
428:<filename>$<envar>TDEDIR</envar>/share/apps/tdm/pics/kdelogo.xpm</filename>

but I don't have such pixmap icon in Slackware, might be a left off from Ubuntu.
Could be renamed tdelogo.png I guess.

There's an occurrence of kdelogo in: ``` doc/tdm/index.docbook 428:<filename>$<envar>TDEDIR</envar>/share/apps/tdm/pics/kdelogo.xpm</filename> ``` but I don't have such pixmap icon in Slackware, might be a left off from Ubuntu. Could be renamed tdelogo.png I guess.
MicheleC commented 6 years ago
Owner

icon is here:

tdebase/tdm/kfrontend/pics/kdelogo.png

Ok to rename in tdelogo.png, of course.

icon is here: tdebase/tdm/kfrontend/pics/kdelogo.png Ok to rename in tdelogo.png, of course.
MicheleC commented 6 years ago
Owner

sorry, didn't notice the extension was different. I suggest to fix the docbook with the correct extension (.png instead of .xpm)

sorry, didn't notice the extension was different. I suggest to fix the docbook with the correct extension (.png instead of .xpm)
Ghost removed the PR/wip label 6 years ago
Ghost commented 6 years ago
Poster

Don't think I'll go further with this PR, please give It a spin!

Don't think I'll go further with this PR, please give It a spin!
MicheleC commented 6 years ago
Owner

This looks good. I will do a test build tomorrow and if all good, I will merge. Unless Slavek can test and merger earlier 😉

This looks good. I will do a test build tomorrow and if all good, I will merge. Unless Slavek can test and merger earlier :wink:
MicheleC closed this pull request 6 years ago
MicheleC deleted branch bug/2618/renameIcon 6 years ago
SlavekB added this to the R14.0.6 release milestone 6 years ago
The pull request has been merged as 3f623d0565.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.6 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#12
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'bug/2618/renameIcon'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes