feature/konq_listview++_14.1 (supercedes pull # 182) #183

Implement additional sorting / grouping options and actions for Konqueror listview, available through new submenu: View => Sort:

Options:

"Group Directories First": Override Konqueror default of always grouping directories before non-directories. Comparable to iconview's "Folders First" option.
"Group Hidden First": Override Konqueror default of always grouping hidden entities before non-hidden.
"Dictionary Order Sorting": Ignore leading "special" character when sorting by Name.

Above options are persisted as settings in config/konqlistviewrc.

Actions:

"Reverse Sort Order": Toggle sort order of the current sort column. Action bound to key Ctrl+R.
"Alternate Sort Order": Toggle sorting between 'primary' sort column (Name) and an 'alternate' sort column that is defined by the last mouse click on a column other than Name. The existing sort order for both primary and alternate sort columns is preserved. Action bound to key Ctrl+S.
The name of the current alternate sort column and the respective sort order of the primary and alternate sort columns is persisted as settings in config/konquerorrc/[Listview_file]

Miscellaneous:

"Detailed List View" is now the default for Konqueror file manager instead of "Icon View"

Caveat: this code was developed and extensively tested on submitter's 14.0.x systems.

Thanks Vince.
I have closed PR #182 since this is a clean replacement of that.
Just for info, it may take a while before we look into it, but we will definitely do 😄 Just be patient.

Update: I just noticed that my implementation of "Dictionary Order Sorting" seems to have messed up sorting on other textual columns like MimeType and Owner. I will need to fix that and update this pull request with a subsequent commit (does that need to be a new pull request?).

Because this PR is still waiting and is labeled WIP, you can definitely use this existing PR. You have two options.

Subsequent commit in this branch.
Make a fix in the appropriate commit (for example, using git rebase -i) to which it applies, and then use force to push new commits in that branch (git push -f origin HEAD).

Hi @VinceR,
the PR is still marked WIP. Are you still working on it or can we start to take a look at it? I see you already pushed a commit to fix the problem you had found.

Hi Michele,

I marked it WIP because that was what I thought I was supposed to do :)
It is ready for your inspection!

Vince

Thanks @VinceR.
WIP usually means a PR is still work-in-progress, so the author still intends to work on it, but it's fine.

I have started to look at this, aiming at merging this soon.
There is a fair bit of rework to do, mostly cleaning up trailing spaces, unnecessary comments, variables/methods naming conventions and so on.
I am preparing a reworked version which I will publish here for you to test before we merge. You will still be credited as the author, since it is just a clean up of your effort 😄

Thanks for the contribution and keep it up. We like to see more and more people getting involved with development and we are happy to help out and support.

Forgot to mentioned that the default view for Konqueror will remain unchanged (Iconview), so that part of the patch will not be merged.

Sorry about all the litter in the code, these were mostly notes to my newbie self as I tried to figure out how to make konqueror work the way I wanted.

Sorry about all the litter in the code, these were mostly notes to my newbie self as I tried to figure out how to make konqueror work the way I wanted.

No worries 😄
Will let you know when the reworked version is completed and you can test it before we merge.

@VinceR
PR #196 is a cleaned up version of this PR + an additional commit to make sure the new menu is displayed in Konqueror.

Before we discuss some of the functionality (dictionary sort will defeinitely need some rework), could you please test on your side to make sure I did not introduce any regression or forget anything useful? It seems ok here, but you will be able to compare with your original work.

This week suddenly got busy, it will be a few days until I can get to it.

This week suddenly got busy, it will be a few days until I can get to it.

No problem Vince, take your time and let us know after you have done the test. There will be things to change (at least for the dictionary order sort) but as mentioned I would prefer to discuss on that starting on the cleaned up code. No rush 😄

Discussion continued over at PR #196

This PR has been replaced by PR #196 and discussion will continue from there. I am therefore closing this and marking it not-ok.

Marking also as "keep branch" for the time being, till PR #196 (or its replacement) will be merged to the master code.

I am removing the original branch to do some clean up. PR#196 and comments are tracking the updated code, so this one is outdated.