Konsole: real transparency checkbox #267

Merged
blu.256 merged 1 commits from feat/konsole-real-transparency into master 2 years ago
Collaborator

This is a small one, it adds the ability to turn on real transparency.

Technically, it adds the ability to turn off the "punch through to desktop" ability introduced in afb2c168c7 to achieve this effect.

This is a small one, it adds the ability to turn on real transparency. Technically, it adds the ability to turn off the "punch through to desktop" ability introduced in afb2c168c783226ad1b97f0b1423def304ae1de9 to achieve this effect.
blu.256 added this to the R14.0.12 release milestone 2 years ago
SlavekB requested changes 2 years ago
SlavekB left a comment
Owner

There are some unwanted changes that were added probably as a result of using the GUI tool.

There are some unwanted changes that were added probably as a result of using the GUI tool.
</property>
<property name="title">
<string></string>
</property>
Owner

It seems that, as a result of the use of the GUI tool, some values that appear unnecessary were added automatically.

It seems that, as a result of the use of the GUI tool, some values that appear unnecessary were added automatically.
SlavekB marked this conversation as resolved
</property>
<property name="accel">
<string>Alt+Z</string>
</property>
Owner

Inadvertently added accel property.

Inadvertently added `accel` property.
SlavekB marked this conversation as resolved
</property>
<property name="accel">
<string>Alt+K</string>
</property>
Owner

Inadvertently added accel property.

Inadvertently added `accel` property.
SlavekB marked this conversation as resolved
</property>
<property name="accel">
<string>Alt+N</string>
</property>
Owner

Inadvertently added accel property.

Inadvertently added `accel` property.
SlavekB marked this conversation as resolved
</property>
<property name="accel">
<string>Alt+R</string>
</property>
Owner

Inadvertently added accel property.

Inadvertently added `accel` property.
SlavekB marked this conversation as resolved
Owner

Would be good to add this for R14.0.12 if we can get the code ready before Friday

Would be good to add this for R14.0.12 if we can get the code ready before Friday
blu.256 force-pushed feat/konsole-real-transparency from 8e6590010e to be19ea8482 2 years ago
Poster
Collaborator

Yes, those inserted properties were an annoying side-effect of using TQt Designer, removed them.

Yes, those inserted properties were an annoying side-effect of using TQt Designer, removed them.
blu.256 requested review from SlavekB 2 years ago
SlavekB requested changes 2 years ago
SlavekB left a comment
Owner

Thank you for solving unwantedly added accel. However, there is a second problem.

For an unknown reason, the row order is stirred in the source file so that it is different from the order of lines in the dialog box. For example, row="8" is moved between row="12" and row="16", which themselves are not correctly sorted on the rows in which they belong (13 to 15). This change of rows order causes confused switching order when using the Tab key.

Please, you can keep the continuous order of lines? In order to order in the source file and the order in the dialog box, it is consistent. And thanks to this, the use of Tab keys naturally worked correctly?

Thank you for solving unwantedly added `accel`. However, there is a second problem. For an unknown reason, the row order is stirred in the source file so that it is different from the order of lines in the dialog box. For example, `row="8"` is moved between `row="12"` and `row="16"`, which themselves are not correctly sorted on the rows in which they belong (13 to 15). This change of rows order causes confused switching order when using the Tab key. Please, you can keep the continuous order of lines? In order to order in the source file and the order in the dialog box, it is consistent. And thanks to this, the use of Tab keys naturally worked correctly?
Owner

Would be good to add this for R14.0.12 if we can get the code ready before Friday

I firmly believe that the remaining minor problems can be successfully resolved before freezing for R14.0.12.

> Would be good to add this for R14.0.12 if we can get the code ready before Friday I firmly believe that the remaining minor problems can be successfully resolved before freezing for R14.0.12.
Owner

the row order is stirred in the source file

Maybe easier to manually edit a clean copy of kcmkonsoledialog.ui and just add the new checkbox? It will avoid things being moved around by TQt/TDE Designer

> the row order is stirred in the source file Maybe easier to manually edit a clean copy of kcmkonsoledialog.ui and just add the new checkbox? It will avoid things being moved around by TQt/TDE Designer
Poster
Collaborator

For an unknown reason, the row order is stirred in the source file so that it is different from the order of lines in the dialog box. For example, row="8" is moved between row="12" and row="16", which themselves are not correctly sorted on the rows in which they belong (13 to 15). This change of rows order causes confused switching order when using the Tab key.

I wonder how the hell did TQt Designer do this?.. :/

Well, I think I'll follow Michele's proposal && manually edit the UI file.

> For an unknown reason, the row order is stirred in the source file so that it is different from the order of lines in the dialog box. For example, row="8" is moved between row="12" and row="16", which themselves are not correctly sorted on the rows in which they belong (13 to 15). This change of rows order causes confused switching order when using the Tab key. I wonder how the hell did TQt Designer do this?.. :/ Well, I think I'll follow Michele's proposal && manually edit the UI file.
blu.256 force-pushed feat/konsole-real-transparency from be19ea8482 to ee161dcf9e 2 years ago
Poster
Collaborator

Just did it manually.

Just did it manually.
blu.256 requested review from SlavekB 2 years ago
SlavekB approved these changes 2 years ago
SlavekB left a comment
Owner

Great, it looks good.
I have no more objections.

Great, it looks good. I have no more objections.
Poster
Collaborator

Doing a last test, then merging + backporting.

Doing a last test, then merging + backporting.
blu.256 merged commit ee161dcf9e into master 2 years ago
blu.256 deleted branch feat/konsole-real-transparency 2 years ago
Poster
Collaborator

Done

Done
Owner

Done

Thank you, builds for PSB and PTB will be started in a while.

> Done Thank you, builds for PSB and PTB will be started in a while.

Reviewers

SlavekB approved these changes 2 years ago
The pull request has been merged as ee161dcf9e.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#267
Loading…
There is no content yet.