Konsole: real transparency checkbox #267
Merged
blu.256
merged 1 commits from feat/konsole-real-transparency
into master
2 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'feat/konsole-real-transparency'
Deleting a branch is permanent. It CANNOT be undone. Continue?
This is a small one, it adds the ability to turn on real transparency.
Technically, it adds the ability to turn off the "punch through to desktop" ability introduced in
afb2c168c7
to achieve this effect.There are some unwanted changes that were added probably as a result of using the GUI tool.
</property>
<property name="title">
<string></string>
</property>
It seems that, as a result of the use of the GUI tool, some values that appear unnecessary were added automatically.
</property>
<property name="accel">
<string>Alt+Z</string>
</property>
Inadvertently added
accel
property.</property>
<property name="accel">
<string>Alt+K</string>
</property>
Inadvertently added
accel
property.</property>
<property name="accel">
<string>Alt+N</string>
</property>
Inadvertently added
accel
property.</property>
<property name="accel">
<string>Alt+R</string>
</property>
Inadvertently added
accel
property.Would be good to add this for R14.0.12 if we can get the code ready before Friday
8e6590010e
tobe19ea8482
2 years agoYes, those inserted properties were an annoying side-effect of using TQt Designer, removed them.
Thank you for solving unwantedly added
accel
. However, there is a second problem.For an unknown reason, the row order is stirred in the source file so that it is different from the order of lines in the dialog box. For example,
row="8"
is moved betweenrow="12"
androw="16"
, which themselves are not correctly sorted on the rows in which they belong (13 to 15). This change of rows order causes confused switching order when using the Tab key.Please, you can keep the continuous order of lines? In order to order in the source file and the order in the dialog box, it is consistent. And thanks to this, the use of Tab keys naturally worked correctly?
I firmly believe that the remaining minor problems can be successfully resolved before freezing for R14.0.12.
Maybe easier to manually edit a clean copy of kcmkonsoledialog.ui and just add the new checkbox? It will avoid things being moved around by TQt/TDE Designer
I wonder how the hell did TQt Designer do this?.. :/
Well, I think I'll follow Michele's proposal && manually edit the UI file.
be19ea8482
toee161dcf9e
2 years agoJust did it manually.
Great, it looks good.
I have no more objections.
Doing a last test, then merging + backporting.
ee161dcf9e
into master 2 years agoDone
Thank you, builds for PSB and PTB will be started in a while.
Reviewers
ee161dcf9e
.