systray: Double program icons in the system tray #414

Signed-off-by: Roman Savochenko roman@roman.home

Prevents the system tray from show program icons with different WMID but equal names like to BlueMan.

This patch is not acceptable as is. If you have two different windows with the same name, you will lose the icon for the second window.
I did a simple test: build kicker with the patch, open two kcalc windows and use tdedocker to dock them to the system tray. Only one icon is shown and when the first kcalc is undocked and closed, the second kcalc is not accessible anywhere. I had to kill kcalc from htop.

Perhaps a better suggestion would be to have a menu associated with icons with the same name: this way the user can use the submenu to select the required window.

For the records, this PR relates to issue #413

In the case of BlueMan the window in fact single due to I cannot to close one without closing other.
And I never start kcalc or some other like that in the system tray, only krusader and it is always is single. :)

I normally use KOrn or KBiff to monitor mailboxes. In the case of KOrn there I have set more configurations with different rules where each configuration shows its own icon. With KBiff I run more instances, each with different configuration with different rules. Again each KBiff with their own icon. This PR, as it is, would break the required functionality.

OK, when this feature will be optional also as "Show Clock in the system tray"?

Appended for the check box "Oppress double named icons".

NoDoubleIcons.png

54 KiB

Appended for the check box "Oppress double named icons".

You are missing the point @roman, it is not about having one config option or not.
Hiding icons for multiple windows with the same name is wrong, it makes windows no longer accessible. There is no way a PR like that would be accepted.
What would be accepted is a PR where windows with the same name are grouped together in a submenu and use the icon as access to that menu. Pretty much what the taskbar does if grouping is selected, to explain the idea. That way, all windows are always accessible while at the same time using a single icon slot in the systray applet.

EDIT: the config option would decide whether to group windows or not.

For me that is about to show in the system tray only icons of the system-service programs, which is only one always, then that is true.
So use the task bar for grouping and not the system tray.

systray: Double program icons in the system tray #414

Reviewers