TDE
/
tdebase
9
3
Fork 1
Code Issues 119 Pull Requests 12 Releases Wiki Activity
Labels Milestones

Adds thumbnail generation for WebP images #487

Merged
SlavekB merged 1 commits from feat/webp-thumbnail-support into master 3 weeks ago
Conversation 1 Commits 1 Files Changed 1
AlexKent commented 3 weeks ago
Collaborator

Signed-off-by: Alex Kent Hajnal software@alephnull.net

This patch adds automatic thumbnail generation for WebP images if kimgio supports reading WebP images. Such read support is provided by TDE/tdelibs#277

If kimgio does not support reading WebP images then no adverse effects appear to occur (i.e. no thumbnails are generated for WebP, other formats are unaffected).

This fixes #380

Signed-off-by: Alex Kent Hajnal <software@alephnull.net> This patch adds automatic thumbnail generation for WebP images if `kimgio` supports reading WebP images. Such read support is provided by https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/pulls/277 If `kimgio` does not support reading WebP images then no adverse effects appear to occur (i.e. no thumbnails are generated for WebP, other formats are unaffected). This fixes https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/issues/380
🚀 1
AlexKent added 1 commit 3 weeks ago
e881ae4719
Adds thumbnail generation for WebP images
AlexKent requested review from SlavekB 3 weeks ago
AlexKent requested review from MicheleC 3 weeks ago
AlexKent added the PR/rfc label 3 weeks ago
AlexKent added a new dependency 3 weeks ago
#380 Support .webp thumbnails in Konqueror
AlexKent changed title from WIP: Adds thumbnail generation for WebP images to Adds thumbnail generation for WebP images 3 weeks ago
SlavekB approved these changes 3 weeks ago
SlavekB left a comment
Owner

It looks good.

It looks good.
SlavekB commented 3 weeks ago
Owner

You can make an amend on commit and add line as: This resolves issue #380 to the git log message.

You can make an amend on commit and add line as: `This resolves issue #380` to the git log message.
AlexKent force-pushed feat/webp-thumbnail-support from e881ae4719 to 50c75e9ada 3 weeks ago
SlavekB merged commit 50c75e9ada into master 3 weeks ago
SlavekB deleted branch feat/webp-thumbnail-support 3 weeks ago
SlavekB added this to the R14.1.3 release milestone 3 weeks ago

Reviewers

MicheleC was requested for review 3 weeks ago
SlavekB approved these changes 3 weeks ago
The pull request has been merged as 50c75e9ada.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MicheleC
SlavekB
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.3 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#487
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/webp-thumbnail-support'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes