Fix TDEPrint and rename it to printers, to be consistent. #68

Merged
MicheleC merged 1 commits from fix/tdeprint into master 3 years ago
Chris commented 3 years ago
Collaborator

This was changed most likely by accident in this commit:

https://mirror.git.trinitydesktop.org/cgit/tdebase/commit/?id=aa7079cd

The problem by that was, that it resulted in a inconsistent display of that kcmmodule in TCC. Printers (TDEPrint). Which is inconsistent, if you look for really all other kcmmodules, like kcmkeyboard, mouse, joystick. GenericName is some optional entry, while Name is needed.

Examples how it should look like:

and all other kcmmodules.

There, "Name" is used too. And in fact, that was done this way also for TDEPrint, until that commit above. That had no bad intention, but resulted in beeing inconsistent with other desktop files used for TCC.

Also this renaming was and still is inconsistent with nearly all translations, including original source strings, in which you can read about "Printers" too.

Prove:

Another reason is, that "TDEPrint" isn't not for what new users are looking for. They are looking for "Printers", as they look for "Keyboards" and not "KCMKeyboard". So that made TDEPrint in TCC look out of place before. With that change, it should be perfect again.

That was dicussed with Slavek and I hope it is understandable for all reading that. 👍

Signed-off-by: Chris xchrisx@uber.space

This was changed most likely by accident in this commit: https://mirror.git.trinitydesktop.org/cgit/tdebase/commit/?id=aa7079cd The problem by that was, that it resulted in a inconsistent display of that kcmmodule in TCC. Printers (TDEPrint). Which is inconsistent, if you look for really all other kcmmodules, like kcmkeyboard, mouse, joystick. GenericName is some optional entry, while Name is needed. Examples how it should look like: - https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/src/branch/master/kcontrol/input/mouse.desktop - https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/src/branch/master/kcontrol/joystick/joystick.desktop and all other kcmmodules. There, "Name" is used too. And in fact, that was done this way also for TDEPrint, until that commit above. That had no bad intention, but resulted in beeing inconsistent with other desktop files used for TCC. Also this renaming was and still is inconsistent with nearly all translations, including original source strings, in which you can read about "Printers" too. Prove: - https://mirror.git.trinitydesktop.org/weblate/translate/tdebase/kcmprintmgr/de/?checksum=fa80176518dadede Another reason is, that "TDEPrint" isn't not for what new users are looking for. They are looking for "Printers", as they look for "Keyboards" and not "KCMKeyboard". So that made TDEPrint in TCC look out of place before. With that change, it should be perfect again. That was dicussed with Slavek and I hope it is understandable for all reading that. :+1: Signed-off-by: Chris <xchrisx@uber.space>
MicheleC closed this pull request 3 years ago
MicheleC deleted branch fix/tdeprint 3 years ago
MicheleC added this to the R14.0.7 release milestone 3 years ago
The pull request has been merged as 866114688f.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#68
Loading…
There is no content yet.