TDE
/
tdegraphics
8
0
Fork 0
Code Issues 9 Pull Requests 1 Releases Wiki Activity
Labels Milestones

ksnapshot: add delay functionality to 'Region' mode. #72

Merged
MicheleC merged 1 commits from issue/71/ksnapshot-region-delay into master 6 months ago
Conversation 2 Commits 1 Files Changed 2
MicheleC commented 6 months ago
Owner

During the delay, the user can move around freely, even changing desktop. After the delay is over, the mouse cursor will change into a grabbing cross and a region can be selected.
If there is no delay, the region can be grabbed immediately, as before.
This resolves issue #71.

During the delay, the user can move around freely, even changing desktop. After the delay is over, the mouse cursor will change into a grabbing cross and a region can be selected. If there is no delay, the region can be grabbed immediately, as before. This resolves issue #71.
MicheleC added this to the R14.1.2 release milestone 6 months ago
MicheleC added 1 commit 6 months ago
b2f97450ef
ksnapshot: add delay functionality to 'Region' mode. This resolves issue #71.
MicheleC requested review from Core 6 months ago
MicheleC requested review from Owners 6 months ago
blu.256 commented 6 months ago
Collaborator

Haven't tested but looks good. I expected the fix to be something simple. This also makes me wonder why this limitation was there in the first place.

Haven't tested but looks good. I expected the fix to be something simple. This also makes me wonder why this limitation was there in the first place.
blu.256 approved these changes 6 months ago
MicheleC commented 6 months ago
Poster
Owner

This also makes me wonder why this limitation was there in the first place.

Maybe the original dev didn't use multiple desktops or didn't see the need to switch desktop after clicking "New screenshot". For example I would first go to the desktop where I want to capture a region, then open KSnapshot. But others may want to switch desktop after clicking the button, so the need for this little PR :-)

> This also makes me wonder why this limitation was there in the first place. Maybe the original dev didn't use multiple desktops or didn't see the need to switch desktop after clicking "New screenshot". For example I would first go to the desktop where I want to capture a region, then open KSnapshot. But others may want to switch desktop after clicking the button, so the need for this little PR :-)
MicheleC merged commit b2f97450ef into master 6 months ago
MicheleC deleted branch issue/71/ksnapshot-region-delay 6 months ago

Reviewers

blu.256 approved these changes 6 months ago
TDE/Owners was requested for review 6 months ago
The pull request has been merged as b2f97450ef.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
blu.256
TDE/Owners
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.2 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdegraphics#72
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'issue/71/ksnapshot-region-delay'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes