Please, you can use the issue TDE/tdebase#1 format in commit message to refer issue from another repository? Using the word issue will ensure the generation of reference in Changelog on Wiki. Using the prefix TDE/ will ensure the generation of reference on TGW.
Please, you can use the **issue TDE/tdebase#1** format in commit message to refer issue from another repository? Using the word **issue** will ensure the generation of reference in Changelog on Wiki. Using the prefix **TDE/** will ensure the generation of reference on TGW.
Uhm... I rebuilt tdelibs with this patch, restarted my system and tested, but I don't see the red folder in Konqueror when I select the / folder.
Not sure I am doing something wrong, I don't think I am.
@blu256 Does this work on your system?
Uhm... I rebuilt tdelibs with this patch, restarted my system and tested, but I don't see the red folder in Konqueror when I select the / folder.
Not sure I am doing something wrong, I don't think I am.
@blu256 Does this work on your system?
Great, following the indications from here (thanks @blu256) it works.
My troubles in testing this raise a question: how do we deliver this to the users and make sure the new correct icon is used even if the user dows not clean the cache? It would be great if it just worked, since it is unlikley users will clean their konqueror cache.
Any idea?
Other feedback: open/save dialogs (for example from Kate) use the standard icon, not the red folder for root. We can look into it in a separate PR and in any case a folder icon is used at the moment.
Great, following the indications from [here](https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/issues/192#issue-1642) (thanks @blu256) it works.
My troubles in testing this raise a question: how do we deliver this to the users and make sure the new correct icon is used even if the user dows not clean the cache? It would be great if it just worked, since it is unlikley users will clean their konqueror cache.
Any idea?
Other feedback: open/save dialogs (for example from Kate) use the standard icon, not the red folder for root. We can look into it in a separate PR and in any case a folder icon is used at the moment.
My troubles in testing this raise a question: how do we deliver this to the users and make sure the new correct icon is used even if the user dows not clean the cache? It would be great if it just worked, since it is unlikley users will clean their konqueror cache.
Any idea?
Could we possibly add a release first-start shell script (like tde_release_notes) to sed out the intimidating cache entry?
> My troubles in testing this raise a question: how do we deliver this to the users and make sure the new correct icon is used even if the user dows not clean the cache? It would be great if it just worked, since it is unlikley users will clean their konqueror cache.
> Any idea?
Could we possibly add a release first-start shell script (like `tde_release_notes`) to `sed` out the intimidating cache entry?
Could we possibly add a release first-start shell script (like tde_release_notes) to sed out the intimidating cache entry?
Nice idea. I was thinking about adding a note in the release notes, but your suggestion is much better!
Will you add to this PR?
> Could we possibly add a release first-start shell script (like `tde_release_notes`) to `sed` out the intimidating cache entry?
Nice idea. I was thinking about adding a note in the release notes, but your suggestion is much better!
Will you add to this PR?
I suggest we merge this PR together with the one with the script in tdebase, so it will be easier to test the functionality of the script.
PR is good to merge, in any case.
I suggest we merge this PR together with the one with the script in tdebase, so it will be easier to test the functionality of the script.
PR is good to merge, in any case.
Hi Philippe,
could you change the "tab" to 8 spaces? on systems with tab != 8 spaces, it causes the "if" line to be badly misaligned. Again consistency with the code around the changes.
Hi Philippe,
could you change the "tab" to 8 spaces? on systems with tab != 8 spaces, it causes the "if" line to be badly misaligned. Again consistency with the code around the changes.
@blu256
good practice is to check the surrounding part of the file and try to follow the same indentation.
You could observe that TDE code is badly formatted and you would be perfectly right. For that we have started work on a code format guideline and a framework for automatically check/enforce the code format will be follow, although we still have a long way to go there.
@blu256
good practice is to check the surrounding part of the file and try to follow the same indentation.
You could observe that TDE code is badly formatted and you would be perfectly right. For that we have started work on a code format guideline and a framework for automatically check/enforce the code format will be follow, although we still have a long way to go there.
MicheleC
This resolves issues #128 and tdebase#1.
Please, you can use the issue TDE/tdebase#1 format in commit message to refer issue from another repository? Using the word issue will ensure the generation of reference in Changelog on Wiki. Using the prefix TDE/ will ensure the generation of reference on TGW.
Uhm... I rebuilt tdelibs with this patch, restarted my system and tested, but I don't see the red folder in Konqueror when I select the / folder.
Not sure I am doing something wrong, I don't think I am.
@blu256 Does this work on your system?
ec9fe3cf56tob056cf79823 years agoGreat, following the indications from here (thanks @blu256) it works.
My troubles in testing this raise a question: how do we deliver this to the users and make sure the new correct icon is used even if the user dows not clean the cache? It would be great if it just worked, since it is unlikley users will clean their konqueror cache.
Any idea?
Other feedback: open/save dialogs (for example from Kate) use the standard icon, not the red folder for root. We can look into it in a separate PR and in any case a folder icon is used at the moment.
@SlavekB Is the new commit message OK?
Yes!
Could we possibly add a release first-start shell script (like
tde_release_notes) tosedout the intimidating cache entry?Nice idea. I was thinking about adding a note in the release notes, but your suggestion is much better!
Will you add to this PR?
Will this shell script be a part of this PR? If so, then yes, I need a little time to work on it.
It should probably go into tdebase where we have other start up scripts like starttde, r14-xdg-update and tde_release_notes.
I suggest we merge this PR together with the one with the script in tdebase, so it will be easier to test the functionality of the script.
PR is good to merge, in any case.
i = mimeTypeIcon;// special case: root directory (/) -- Gitea issue #128if ( _url == KURL("file:///") )Hi Philippe,
could you change the "tab" to 8 spaces? on systems with tab != 8 spaces, it causes the "if" line to be badly misaligned. Again consistency with the code around the changes.
Fixed in fafb93170f.
@blu256
good practice is to check the surrounding part of the file and try to follow the same indentation.
You could observe that TDE code is badly formatted and you would be perfectly right. For that we have started work on a code format guideline and a framework for automatically check/enforce the code format will be follow, although we still have a long way to go there.
As per comment below
well, turns out to be "comment above" 😓
Perfect! Can I ask one last think? Squash the two commits into one? I could do it myself but the commit would lose your GPG key :-(
fafb93170fto646661d0be3 years agoDone!
646661d0beinto master 3 years agoGreat, merged and backported.
Reviewers
646661d0be.