TDE
/
tdelibs
7
1
Fork 0
Code Issues 16 Pull Requests 8 Releases Wiki Activity
Labels Milestones

Add definition for X11_RGBFILE and XMLLINT in config.h #109

Merged
MicheleC merged 1 commits from feat/add_definitions into master 4 years ago
Conversation 3 Commits 1 Files Changed 3
Ghost commented 4 years ago

Not stricto sensus needed but why not having them?

You might also request xmllint in your Deb packaging.

Not **stricto sensus** needed but why not having them? You might also request xmllint in your Deb packaging.
MicheleC reviewed 4 years ago
CMakeLists.txt Outdated
##### find the rgb.txt file
message( STATUS "Looking for rgb.txt" )
find_file( PATH_RGB rgb.txt PATHS /usr/share/X11 )
MicheleC commented 4 years ago
Owner

Just curious, why we hint to just one path here and we leave the others separately in tdeui/kcolordialog.cppL#632? Wouldn't it make more sense to add those additional paths here too?

Just curious, why we hint to just one path here and we leave the others separately in tdeui/kcolordialog.cppL#632? Wouldn't it make more sense to add those additional paths here too?
MicheleC approved these changes 4 years ago
MicheleC left a comment
Owner

Looks good to me, other than the comment I wrote before.

Looks good to me, other than the comment I wrote before.
Ghost changed title from Add definition for X11_RGBFILE and XMLLINT in config.h to WIP:Add definition for X11_RGBFILE and XMLLINT in config.h 4 years ago
Ghost added the PR/wip label 4 years ago
Ghost commented 4 years ago
Poster

I'd like to leave it as-is, @MicheleC feel free to adjust to your liking.

I'd like to leave it as-is, @MicheleC feel free to adjust to your liking.
Ghost removed the PR/wip label 4 years ago
Ghost changed title from WIP:Add definition for X11_RGBFILE and XMLLINT in config.h to Add definition for X11_RGBFILE and XMLLINT in config.h 4 years ago
SlavekB reviewed 4 years ago
SlavekB left a comment
Owner

It looks good – just one small note.

It looks good – just one small note.
CMakeLists.txt Outdated
/usr/share/latex2html/styles
/usr/share/nvim/runtime
/usr/X11R6/lib/X11
/usr/openwin/lib/X11
SlavekB commented 4 years ago
Owner

It's great that there is such a large list of paths.

One note: I believe that XOrg/X11 related paths should be listed before other potential paths.

It's great that there is such a large list of paths. One note: I believe that XOrg/X11 related paths should be listed before other potential paths.
MicheleC commented 4 years ago
Owner

We should avoid specific paths (like vim, neovim, latex and so on), as per IRC discussion.

We should avoid specific paths (like vim, neovim, latex and so on), as per IRC discussion.
MicheleC approved these changes 4 years ago
MicheleC left a comment
Owner

Looks good to me

Looks good to me
MicheleC commented 4 years ago
Owner

Greg, could you rebase on top of master? To keep your GPG signature.

Greg, could you rebase on top of master? To keep your GPG signature.
MicheleC merged commit 2706c5674e into master 4 years ago
MicheleC deleted branch feat/add_definitions 4 years ago
MicheleC added this to the R14.0.9 release milestone 4 years ago
MicheleC commented 4 years ago
Owner

Thanks, merge done! 👍

Thanks, merge done! :+1:

Reviewers

MicheleC approved these changes 4 years ago
The pull request has been merged as 2706c5674e.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MicheleC
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.9 release
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdelibs#109
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/add_definitions'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes