TDE
/
tdelibs
7
1
Fork 0
Code Issues 16 Pull Requests 8 Releases Wiki Activity
Labels Milestones

Removed unused code related to hardware events. #143

Merged
MicheleC merged 1 commits from drop/unused-hwevent into master 3 years ago
Conversation 2 Commits 1 Files Changed 3
MicheleC commented 3 years ago
Owner

'hardwareEvent' is mostly unusued, except for the 'HardwareListModified' type used in tdenetworkmanager.
'mountTableModified' is also unusued.

This PR propose to drop the related code.

'hardwareEvent' is mostly unusued, except for the 'HardwareListModified' type used in tdenetworkmanager. 'mountTableModified' is also unusued. This PR propose to drop the related code.
MicheleC added the PR/rfc label 3 years ago
MicheleC force-pushed drop/unused-hwevent from 9e68027f6c to 4a8875301d 3 years ago
MicheleC commented 3 years ago
Poster
Owner

Updated as per jabber discussion.

Updated as per jabber discussion.
SlavekB approved these changes 3 years ago
SlavekB left a comment
Owner

It seems that the general signal hardwareEvent is really unnecessary because it is always useful to use a specific signal, such as adding, removing and change.

It looks good, nothing seems to prevent it from being merged.

It seems that the general signal `hardwareEvent` is really unnecessary because it is always useful to use a specific signal, such as adding, removing and change. It looks good, nothing seems to prevent it from being merged.
MicheleC merged commit 4a8875301d into master 3 years ago
MicheleC added this to the R14.1.0 release milestone 3 years ago
MicheleC removed the PR/rfc label 3 years ago
MicheleC deleted branch drop/unused-hwevent 3 years ago
MicheleC commented 3 years ago
Poster
Owner

Thanks for the feedback Slavek. As discussed, this PR is only for R14.1.0 because it is a change of API.

Thanks for the feedback Slavek. As discussed, this PR is only for R14.1.0 because it is a change of API.

Reviewers

SlavekB approved these changes 3 years ago
The pull request has been merged as 4a8875301d.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.0 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Depends on
#7 Removed unused hardwareEvent code - part 2.
TDE/tdenetworkmanager
#6 Removed unused hardwareEvent code.
TDE/tdenetworkmanager
Reference: TDE/tdelibs#143
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'drop/unused-hwevent'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes