dcopclient: Use default path for XDG_RUNTIME_DIR if the variable is not set #146

Looks good but it will be better to fix the indentation of the code.

Running something like this

/opt/trinity/bin/dcop --user killy --session .DCOPserver_skynet__0 kdesktop KScreensaverIface lock

from a "su -" CLI session seems to work. But running the same from a non-root session (i.e. different user) doesn't, so we should ask @jstolarek to test it before we merge it.

Sorry, but why does the path end with <uid> on line 604? Is this some kind of argument/placeholder? But I don't see it substituted anywhere.

Sorry, but why does the path end with <uid> on line 604? Is this some kind of argument/placeholder? But I don't see it substituted anywhere.

Yes, it's like a placeholder. On line 612 you can see that only the name of the parent folder is used – xdgRuntime.dirPath().

Running something like this
/opt/trinity/bin/dcop --user killy --session .DCOPserver_skynet__0 kdesktop KScreensaverIface lock
from a "su -" CLI session seems to work. But running the same from a non-root session (i.e. different user) doesn't, so we should ask @jstolarek to test it before we merge it.

Calls can only be used if user has permission to read ICEAuthhority of a foreign user. This usually has only root.

Calls can only be used if user has permission to read ICEAuthhority of a foreign user. This usually has only root.

The point I was trying to make was that if the script of @jstolarek is called as a different user (acpid??), it may still not work, hence the need for testing.

Well, if things used to work on my machine before the regression then I'm guessing it must've been run with root permissions. If it works with root that's fine with me.

It works with root, I tested.
About regression, this could have been caused by something else, not TDE, so it could turn out it still didn't work once this is merged. In any case, I think we can merge this and then you give it a go with the new packages and we take it from there.

Originally I made a change to be minimal. But, it is true that indentation in this part of the code was very inconsistent. Now I changed the entire if block indentation. At the same time, I used the fromLocal8bit() and local8Bit() to manipulate with environment variables.

Looks good

I'll let you know once I test the changes. When to expect updated package in the repo? It will be in the PBS I presume?

I'll let you know once I test the changes. When to expect updated package in the repo? It will be in the PBS I presume?

Yes, updated packages will be available in PSB pepository. And currently should already be provided for installation (tdelibs version 14.0.12~pre2).

I can confirm this fix works as expected. Thanks!

I can confirm this fix works as expected. Thanks!

Great, thank you for confirmation.

dcopclient: Use default path for XDG_RUNTIME_DIR if the variable is not set #146

Reviewers