Replaced various '#define' with actual strings - part 6 #249

Merged
MicheleC merged 1 commits from replace/tqt-defines-6 into master 4 months ago
Owner

Those defines will later be removed from tqtinterface.

Those defines will later be removed from tqtinterface.
MicheleC added this to the R14.1.2 release milestone 4 months ago
MicheleC added 1 commit 4 months ago
e7aa2ec0b3
Replace various '#define' strings - part 6
MicheleC requested review from Core 4 months ago
MicheleC requested review from Owners 4 months ago
MicheleC force-pushed replace/tqt-defines-6 from e7aa2ec0b3 to d5688771d8 4 months ago
SlavekB reviewed 4 months ago
SlavekB left a comment
Owner

All looks good. Only one note for small cosmetic deficiency.

All looks good. Only one note for small cosmetic deficiency.
{
if (p->device() && p->device()->devType() == TQInternal::Widget &&
TQCString(TQT_TQWIDGET(p->device())->className()) == "FittsLawFrame" )
TQCString(static_cast<TQWidget*>(p->device())->className()) == "FittsLawFrame" )
Owner

Unwanted change of indentation?

Unwanted change of indentation?
Poster
Owner

I don't see any change of indentation from the original file (11 tabs and 1 space). I double checked just in case.
As per indentation rules, as you know we will soon start enforcing/rectifying them separately.

I don't see any change of indentation from the original file (11 tabs and 1 space). I double checked just in case. As per indentation rules, as you know we will soon start enforcing/rectifying them separately.
Owner

It is possible that this is only due to the display in TGW. Because soon the indentation will be reformated, I do not have any other objections.

It is possible that this is only due to the display in TGW. Because soon the indentation will be reformated, I do not have any other objections.
SlavekB marked this conversation as resolved
SlavekB approved these changes 4 months ago
SlavekB left a comment
Owner

All looks good.
The previous note explained as a difference in the view during revising.

All looks good. The previous note explained as a difference in the view during revising.
MicheleC merged commit d5688771d8 into master 4 months ago
MicheleC deleted branch replace/tqt-defines-6 4 months ago

Reviewers

SlavekB approved these changes 4 months ago
TDE/Core was requested for review 4 months ago
The pull request has been merged as d5688771d8.
Sign in to join this conversation.
No reviewers
TDE/Core
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdelibs#249
Loading…
There is no content yet.