Replace KDE_Q_EXPORT_PLUGIN, KDE_PACKED and KDE_WEAK_SYMBOL with TDE_* equivalent #278
Merged
MicheleC
merged 1 commits from replace/kde_macros into master 4 months ago
SlavekB
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'replace/kde_macros'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Original KDE_* defines are still present and will be removed when the renaming is completed in all TDE code.
There are some questions and comments.
#ifndef _KDE_MACROS_H_#define _KDE_MACROS_H_#ifndef _TDE_MACROS_H_#define _TDE_MACROS_H_I suppose that the change of the header guard should be associated with the renaming of the file.
Good point, I will amend.
/*** KDE_Q_EXPORT_PLUGIN is a workaround for Qt not being able to* TDE_Q_EXPORT_PLUGIN is a workaround for Qt not being able toWhen a name change is made, is it a good idea to change
_Q_=>_TQ_?#ifndef _KDE_MACROS_H_#define _KDE_MACROS_H_#ifndef _TDE_MACROS_H_#define _TDE_MACROS_H_I suppose that the change of the header guard should be associated with the renaming of the file.
/*** KDE_Q_EXPORT_PLUGIN is a workaround for Qt not being able to* TDE_Q_EXPORT_PLUGIN is a workaround for Qt not being able toWhen a name change is made, is it a good idea to change
_Q_=>_TQ_?f418906b9dto0f0c5a4d074 months agoPR updated
All looks good.
0f0c5a4d07into master 4 months agoReviewers
0f0c5a4d07.