Replace QObject, QWidget, QImage, QPair, QRgb, QColor, QChar, QString, QIODevice with TQ* version #29

Merged
MicheleC merged 1 commits from replace/qobjects into master 7 months ago
Owner

As per title.

Don't get fool by Gitea when reviewing .diff files.

As per title. Don't get fool by Gitea when reviewing .diff files.
MicheleC added this to the R14.1.1 release milestone 7 months ago
MicheleC added 1 commit 7 months ago
MicheleC requested review from Core 7 months ago
MicheleC requested review from Owners 7 months ago
SlavekB reviewed 7 months ago
SlavekB left a comment
Owner

It looks like quite bold to make changes in the diff file, although they are just for testing. Are you sure we want to do it?
Next to this, there are some comments about changes in history records.
And there are renames in parts that relate to Qt4/KDE code.

It looks like quite bold to make changes in the diff file, although they are just for testing. Are you sure we want to do it? Next to this, there are some comments about changes in history records. And there are renames in parts that relate to Qt4/KDE code.
* Use DCOP stubs to access the methods of the cvs DCOP service
* Added new method update() and checkout() to DCOP service
* Use TDEProcess::operator<< instead of QString::operator+= to
* Use TDEProcess::operator<< instead of TQString::operator+= to
Owner

Does it make sense to edit history records?

Does it make sense to edit history records?
MicheleC marked this conversation as resolved
Feb-04-2001 - Kurt Granroth (v1.0.3)
o Converted App::load method to use KURL instead of QString in kapp
o Converted App::load method to use KURL instead of TQString in kapp
Owner

Does it make sense to edit history records?

Does it make sense to edit history records?
MicheleC marked this conversation as resolved
Sep 22, 2003 : Otto Bruggeman
* Added openStdin() to KompareShell
* Fixed stupid implicit conversion from QString to QStringList in kompare_part.cpp
* Fixed stupid implicit conversion from TQString to QStringList in kompare_part.cpp
Owner

Does it make sense to edit history records?

Does it make sense to edit history records?
MicheleC marked this conversation as resolved
end
document printq4string
Prints the contents of a Qt QString
Prints the contents of a Qt TQString
Owner

The code is probably related to Qt4, renaming seems not appropriate.

The code is probably related to Qt4, renaming seems not appropriate.
MicheleC marked this conversation as resolved
end
document printq4stringdata
Prints the contents of a Qt4 QString::Data
Prints the contents of a Qt4 TQString::Data
Owner

The code is probably related to Qt4, renaming seems not appropriate.

The code is probably related to Qt4, renaming seems not appropriate.
MicheleC marked this conversation as resolved
shows {d = 0xdeadbeef} for a QString, i.e. the qstringdata address
instead of the QString object itself.
shows {d = 0xdeadbeef} for a TQString, i.e. the qstringdata address
instead of the TQString object itself.
Owner

The code is probably related to Qt4, renaming seems not appropriate.

The code is probably related to Qt4, renaming seems not appropriate.
Owner

In one line, unwanted renaming was resolved, remaining in the second line 😉

In one line, unwanted renaming was resolved, remaining in the second line 😉
Poster
Owner

ah yes, my bad. I missed the second one. PR updated.

ah yes, my bad. I missed the second one. PR updated.
MicheleC marked this conversation as resolved
# Bad implementation, requires a running process.
# Needs to be refined, i.e. figuring out the right void* pointers casts.
# Simon says: each Node contains the d pointer of the QString.
# Simon says: each Node contains the d pointer of the TQString.
Owner

The code is probably related to Qt4, renaming seems not appropriate.

The code is probably related to Qt4, renaming seems not appropriate.
MicheleC marked this conversation as resolved
elseif a:ident =~ 'QListBox.*'
return '<qlistbox.h>'
elseif a:ident == 'QChar' ||
elseif a:ident == 'TQChar' ||
Owner

This file seems to be concentrated on Qt/KDE code and no renaming changes have been made. Making little renaming now makes it inconsistent.

This file seems to be concentrated on Qt/KDE code and no renaming changes have been made. Making little renaming now makes it inconsistent.
Poster
Owner

It will look inconsistent for a while, but overtime we will need to replace all those Q* object names with TQ* ones. The vim macro looks for an include file based on the type name, so using Q* types will not work with TQt3.

It will look inconsistent for a while, but overtime we will need to replace all those Q* object names with TQ* ones. The vim macro looks for an include file based on the type name, so using Q* types will not work with TQt3.
Owner

There it seemed to me that the renames for the time being passed this file and that it was consistently old. But as I see, some renaming was done, so the file is really already in an inconsistent state. So ok, other inconsistency does not make the condition worse.

There it seemed to me that the renames for the time being passed this file and that it was _consistently old_. But as I see, some renaming was done, so the file is really already in an inconsistent state. So ok, other inconsistency does not make the condition worse.
MicheleC marked this conversation as resolved
(qvalidator.h QIntValidator QDoubleValidator QRegExpValidator)
(qlistbox.h QListBoxItem QListBoxText QListBoxPixmap)
(qstring.h QChar QCharRef QConstString)
(qstring.h TQChar QCharRef QConstString)
Owner

This file seems to be concentrated on Qt/KDE code and no renaming changes have been made. Making little renaming now makes it inconsistent.

This file seems to be concentrated on Qt/KDE code and no renaming changes have been made. Making little renaming now makes it inconsistent.
Poster
Owner

Likewise, we will be renaming more and more over time as we progress the Qt -> TQt conversion.

Likewise, we will be renaming more and more over time as we progress the Qt -> TQt conversion.
MicheleC marked this conversation as resolved
MicheleC force-pushed replace/qobjects from cbf17787e6 to d6fa23bc92 7 months ago
Poster
Owner

PR updated for all resolved points.

PR updated for all resolved points.
MicheleC force-pushed replace/qobjects from d6fa23bc92 to 0ffe839d6e 7 months ago
SlavekB approved these changes 7 months ago
SlavekB left a comment
Owner

All seems good.

All seems good.
MicheleC merged commit 0ffe839d6e into master 7 months ago
MicheleC deleted branch replace/qobjects 7 months ago

Reviewers

SlavekB approved these changes 7 months ago
TDE/Core was requested for review 7 months ago
The pull request has been merged as 0ffe839d6e.
Sign in to join this conversation.
No reviewers
TDE/Core
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdesdk#29
Loading…
There is no content yet.