#1 Fix portability for expr(1) usage

Merged
SlavekB merged 1 commits from feat/fix-expr-portability into master 3 months ago
obache commented 3 months ago

“match” operand for expr(1) is GNU extension. Change to use the standard way to match regex with expr(1).

"match" operand for expr(1) is GNU extension. Change to use the standard way to match regex with expr(1).
SlavekB approved these changes 3 months ago
Everything looks good.
SlavekB changed title from WIP: Fix portability for expr(1) usage to Fix portability for expr(1) usage 3 months ago
SlavekB deleted branch feat/fix-expr-portability 3 months ago
MicheleC commented 3 months ago
Owner

Thanks Obata-san.

Just as a reminder, there is no need to add WIP in the title of the PR.
A PR marked as WIP means you intend to do more work on it and should not be merged yet.
I read the TGW guide again and there is no mentioning of WIP, unless I totally missed it.

Thanks Obata-san. Just as a reminder, there is no need to add WIP in the title of the PR.<br> A PR marked as WIP means you intend to do more work on it and should not be merged yet.<br> I read the TGW guide again and there is no mentioning of WIP, unless I totally missed it.
SlavekB added this to the R14.0.6 release milestone 3 months ago
SlavekB commented 3 months ago
Owner

@obache, you can use a different way. Instead of WIP to the PR name, you can set label PR/rfc. By doing so, you acknowledge that your work is completed and you want us to review the proposed PR.

@obache, you can use a different way. Instead of WIP to the PR name, you can set label PR/rfc. By doing so, you acknowledge that your work is completed and you want us to review the proposed PR.
obache commented 3 months ago
Poster

Have you ever created PR here?

below the title input area: “Start the title with WIP: to prevent the pull request from being merged accidentally.”

Have you ever created PR here? below the title input area: "Start the title with WIP: to prevent the pull request from being merged accidentally."
SlavekB commented 3 months ago
Owner

Yes, but it does not make sense to keep the WIP tag when you really want to merge :smiley_cat:

As we said – WIP means that you’re still working on PR == is not ready for merge. If PR is ready to merge, the WIP tag is confusing.

Yes, but it does not make sense to keep the WIP tag when you really want to merge :smiley_cat: As we said – WIP means that you're still working on PR == is not ready for merge. If PR is ready to merge, the WIP tag is confusing.

Reviewers

SlavekB approved these changes 3 months ago
The pull request has been merged.
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.