Fix portability for expr(1) usage #1

Обединени
SlavekB обедини 1 ревизии от feat/fix-expr-portability във master преди 5 години
Сътрудник

"match" operand for expr(1) is GNU extension.
Change to use the standard way to match regex with expr(1).

"match" operand for expr(1) is GNU extension. Change to use the standard way to match regex with expr(1).
SlavekB approved these changes преди 5 години
SlavekB left a comment
Притежател

Everything looks good.

Everything looks good.
SlavekB changed title from WIP: Fix portability for expr(1) usage to Fix portability for expr(1) usage преди 5 години
SlavekB closed this pull request преди 5 години
SlavekB deleted branch feat/fix-expr-portability преди 5 години
Притежател

Thanks Obata-san.

Just as a reminder, there is no need to add WIP in the title of the PR.

A PR marked as WIP means you intend to do more work on it and should not be merged yet.

I read the TGW guide again and there is no mentioning of WIP, unless I totally missed it.

Thanks Obata-san. Just as a reminder, there is no need to add WIP in the title of the PR.<br> A PR marked as WIP means you intend to do more work on it and should not be merged yet.<br> I read the TGW guide again and there is no mentioning of WIP, unless I totally missed it.
SlavekB added this to the R14.0.6 release milestone преди 5 години
Притежател

@obache, you can use a different way. Instead of WIP to the PR name, you can set label PR/rfc. By doing so, you acknowledge that your work is completed and you want us to review the proposed PR.

@obache, you can use a different way. Instead of WIP to the PR name, you can set label PR/rfc. By doing so, you acknowledge that your work is completed and you want us to review the proposed PR.
Участник
Сътрудник

Have you ever created PR here?

below the title input area:
"Start the title with WIP: to prevent the pull request from being merged accidentally."

Have you ever created PR here? below the title input area: "Start the title with WIP: to prevent the pull request from being merged accidentally."
Притежател

Yes, but it does not make sense to keep the WIP tag when you really want to merge 😺

As we said – WIP means that you're still working on PR == is not ready for merge. If PR is ready to merge, the WIP tag is confusing.

Yes, but it does not make sense to keep the WIP tag when you really want to merge :smiley_cat: As we said – WIP means that you're still working on PR == is not ready for merge. If PR is ready to merge, the WIP tag is confusing.
Тази заявка за сливане е била обединена като 8b1ffe85f3.
Впишете се за да се присъедините към разговора.
No reviewers
Няма етап
Няма изпълнители
3 участника
Известия
Due Date

No due date set.

Зависимости

No dependencies set.

Reference: TDE/tqca-tls#1
Зареждане…
Все още няма съдържание.