6
0
Fork 0

Fix portability for expr(1) usage #1

Zusammengeführt
SlavekB hat 1 Commits von feat/fix-expr-portability nach master vor 5 Jahren zusammengeführt
obache hat vor 5 Jahren kommentiert
Mitarbeiter

"match" operand for expr(1) is GNU extension.
Change to use the standard way to match regex with expr(1).

"match" operand for expr(1) is GNU extension. Change to use the standard way to match regex with expr(1).
SlavekB hat die Änderungen vor 5 Jahren genehmigt
SlavekB hat einen Kommentar hinterlassen
Besitzer

Everything looks good.

Everything looks good.
SlavekB hat den Titel von WIP: Fix portability for expr(1) usage zu Fix portability for expr(1) usage vor 5 Jahren geändert
SlavekB hat diesen Pull-Request vor 5 Jahren geschlossen
SlavekB löschte die Branch feat/fix-expr-portability vor 5 Jahren
MicheleC hat vor 5 Jahren kommentiert
Besitzer

Thanks Obata-san.

Just as a reminder, there is no need to add WIP in the title of the PR.

A PR marked as WIP means you intend to do more work on it and should not be merged yet.

I read the TGW guide again and there is no mentioning of WIP, unless I totally missed it.

Thanks Obata-san. Just as a reminder, there is no need to add WIP in the title of the PR.<br> A PR marked as WIP means you intend to do more work on it and should not be merged yet.<br> I read the TGW guide again and there is no mentioning of WIP, unless I totally missed it.
SlavekB hat diesen Issue vor 5 Jahren zum R14.0.6 release Meilenstein hinzugefügt
SlavekB hat vor 5 Jahren kommentiert
Besitzer

@obache, you can use a different way. Instead of WIP to the PR name, you can set label PR/rfc. By doing so, you acknowledge that your work is completed and you want us to review the proposed PR.

@obache, you can use a different way. Instead of WIP to the PR name, you can set label PR/rfc. By doing so, you acknowledge that your work is completed and you want us to review the proposed PR.
obache hat vor 5 Jahren kommentiert
Ersteller
Mitarbeiter

Have you ever created PR here?

below the title input area:
"Start the title with WIP: to prevent the pull request from being merged accidentally."

Have you ever created PR here? below the title input area: "Start the title with WIP: to prevent the pull request from being merged accidentally."
SlavekB hat vor 5 Jahren kommentiert
Besitzer

Yes, but it does not make sense to keep the WIP tag when you really want to merge 😺

As we said – WIP means that you're still working on PR == is not ready for merge. If PR is ready to merge, the WIP tag is confusing.

Yes, but it does not make sense to keep the WIP tag when you really want to merge :smiley_cat: As we said – WIP means that you're still working on PR == is not ready for merge. If PR is ready to merge, the WIP tag is confusing.
Der Pull Request wurde als 8b1ffe85f3 gemergt.
Anmelden, um an der Diskussion teilzunehmen.
Keine Reviewer
Kein Meilenstein
Niemand zuständig
3 Beteiligte
Nachrichten
Fällig am

Kein Fälligkeitsdatum gesetzt.

Abhängigkeiten

Keine Abhängigkeiten gesetzt.

Referenz: TDE/tqca-tls#1
Laden…
Hier gibt es bis jetzt noch keinen Inhalt.