Fix portability for expr(1) usage #1

병합
SlavekB feat/fix-expr-portability 에서 master 로 1 commits 를 머지했습니다 5 년 전
obache 코멘트됨, 5 년 전
협업자

"match" operand for expr(1) is GNU extension.
Change to use the standard way to match regex with expr(1).

"match" operand for expr(1) is GNU extension. Change to use the standard way to match regex with expr(1).
SlavekB 이 변경사항을 승인하였습니다. 5 년 전
SlavekB left a comment
소유자

Everything looks good.

Everything looks good.
SlavekB changed title from WIP: Fix portability for expr(1) usage to Fix portability for expr(1) usage 5 년 전
SlavekB closed this pull request 5 년 전
SlavekB 삭제된 브랜치 feat/fix-expr-portability 5 년 전
MicheleC 코멘트됨, 5 년 전
소유자

Thanks Obata-san.

Just as a reminder, there is no need to add WIP in the title of the PR.

A PR marked as WIP means you intend to do more work on it and should not be merged yet.

I read the TGW guide again and there is no mentioning of WIP, unless I totally missed it.

Thanks Obata-san. Just as a reminder, there is no need to add WIP in the title of the PR.<br> A PR marked as WIP means you intend to do more work on it and should not be merged yet.<br> I read the TGW guide again and there is no mentioning of WIP, unless I totally missed it.
SlavekB R14.0.6 release 5 년 전 마일스톤을 추가하였습니다.
SlavekB 코멘트됨, 5 년 전
소유자

@obache, you can use a different way. Instead of WIP to the PR name, you can set label PR/rfc. By doing so, you acknowledge that your work is completed and you want us to review the proposed PR.

@obache, you can use a different way. Instead of WIP to the PR name, you can set label PR/rfc. By doing so, you acknowledge that your work is completed and you want us to review the proposed PR.
obache 코멘트됨, 5 년 전
포스터
협업자

Have you ever created PR here?

below the title input area:
"Start the title with WIP: to prevent the pull request from being merged accidentally."

Have you ever created PR here? below the title input area: "Start the title with WIP: to prevent the pull request from being merged accidentally."
SlavekB 코멘트됨, 5 년 전
소유자

Yes, but it does not make sense to keep the WIP tag when you really want to merge 😺

As we said – WIP means that you're still working on PR == is not ready for merge. If PR is ready to merge, the WIP tag is confusing.

Yes, but it does not make sense to keep the WIP tag when you really want to merge :smiley_cat: As we said – WIP means that you're still working on PR == is not ready for merge. If PR is ready to merge, the WIP tag is confusing.
The pull request has been merged as 8b1ffe85f3.
로그인하여 이 대화에 참여
No reviewers
마일스톤 없음
담당자 없음
참여자 3명
알림
마감일

마감일이 설정되지 않았습니다.

의존성

No dependencies set.

Reference: TDE/tqca-tls#1
불러오는 중...
아직 콘텐츠가 없습니다.