Fix portability for expr(1) usage #1

Samengevoegd
SlavekB heeft 1 commits samengevoegd van feat/fix-expr-portability naar master 5 jaren geleden
Medewerker

"match" operand for expr(1) is GNU extension.
Change to use the standard way to match regex with expr(1).

"match" operand for expr(1) is GNU extension. Change to use the standard way to match regex with expr(1).
SlavekB heeft deze veranderingen 5 jaren geleden goedgekeurd
SlavekB heeft een reactie achtergelaten
Eigenaar

Everything looks good.

Everything looks good.
SlavekB titel aangepast van WIP: Fix portability for expr(1) usage naar Fix portability for expr(1) usage 5 jaren geleden
SlavekB heeft deze pull request gesloten 5 jaren geleden
SlavekB heeft 5 jaren geleden de branch feat/fix-expr-portability verwijderd.
Eigenaar

Thanks Obata-san.

Just as a reminder, there is no need to add WIP in the title of the PR.

A PR marked as WIP means you intend to do more work on it and should not be merged yet.

I read the TGW guide again and there is no mentioning of WIP, unless I totally missed it.

Thanks Obata-san. Just as a reminder, there is no need to add WIP in the title of the PR.<br> A PR marked as WIP means you intend to do more work on it and should not be merged yet.<br> I read the TGW guide again and there is no mentioning of WIP, unless I totally missed it.
SlavekB heeft dit 5 jaren geleden aan de mijlpaal R14.0.6 release toegevoegd
Eigenaar

@obache, you can use a different way. Instead of WIP to the PR name, you can set label PR/rfc. By doing so, you acknowledge that your work is completed and you want us to review the proposed PR.

@obache, you can use a different way. Instead of WIP to the PR name, you can set label PR/rfc. By doing so, you acknowledge that your work is completed and you want us to review the proposed PR.
Poster
Medewerker

Have you ever created PR here?

below the title input area:
"Start the title with WIP: to prevent the pull request from being merged accidentally."

Have you ever created PR here? below the title input area: "Start the title with WIP: to prevent the pull request from being merged accidentally."
Eigenaar

Yes, but it does not make sense to keep the WIP tag when you really want to merge 😺

As we said – WIP means that you're still working on PR == is not ready for merge. If PR is ready to merge, the WIP tag is confusing.

Yes, but it does not make sense to keep the WIP tag when you really want to merge :smiley_cat: As we said – WIP means that you're still working on PR == is not ready for merge. If PR is ready to merge, the WIP tag is confusing.
De pull request is samengevoegd als 8b1ffe85f3.
Log in om deel te nemen aan deze discussie.
Geen beoordelaars
Geen mijlpaal
Niet toegewezen
3 deelnemers
Notificaties
Vervaldatum

Geen vervaldatum ingesteld.

Afhankelijkheden

Geen afhankelijkheden ingesteld.

Referentie: TDE/tqca-tls#1
Laden…
Er is nog geen inhoud.