Fix portability for expr(1) usage #1

Birleştirildi
SlavekB 5 yıl önce feat/fix-expr-portability içindeki 1 işlemeyi master ile birleştirdi
obache 5 yıl önce yorum yaptı
Katkıcı

"match" operand for expr(1) is GNU extension.
Change to use the standard way to match regex with expr(1).

"match" operand for expr(1) is GNU extension. Change to use the standard way to match regex with expr(1).
SlavekB 5 yıl önce bu değişiklikleri onayladı
SlavekB bir yorum yaptı
Sahibi

Everything looks good.

Everything looks good.
SlavekB başlığı WIP: Fix portability for expr(1) usage iken Fix portability for expr(1) usage olarak 5 yıl önce değiştirdi
SlavekB 5 yıl önce değişiklik isteğini kapattı
SlavekB feat/fix-expr-portability dalı silindi 5 yıl önce
MicheleC 5 yıl önce yorum yaptı
Sahibi

Thanks Obata-san.

Just as a reminder, there is no need to add WIP in the title of the PR.

A PR marked as WIP means you intend to do more work on it and should not be merged yet.

I read the TGW guide again and there is no mentioning of WIP, unless I totally missed it.

Thanks Obata-san. Just as a reminder, there is no need to add WIP in the title of the PR.<br> A PR marked as WIP means you intend to do more work on it and should not be merged yet.<br> I read the TGW guide again and there is no mentioning of WIP, unless I totally missed it.
SlavekB 5 yıl önce R14.0.6 release kilometre taşına ekledi
SlavekB 5 yıl önce yorum yaptı
Sahibi

@obache, you can use a different way. Instead of WIP to the PR name, you can set label PR/rfc. By doing so, you acknowledge that your work is completed and you want us to review the proposed PR.

@obache, you can use a different way. Instead of WIP to the PR name, you can set label PR/rfc. By doing so, you acknowledge that your work is completed and you want us to review the proposed PR.
obache 5 yıl önce yorum yaptı
Poster
Katkıcı

Have you ever created PR here?

below the title input area:
"Start the title with WIP: to prevent the pull request from being merged accidentally."

Have you ever created PR here? below the title input area: "Start the title with WIP: to prevent the pull request from being merged accidentally."
SlavekB 5 yıl önce yorum yaptı
Sahibi

Yes, but it does not make sense to keep the WIP tag when you really want to merge 😺

As we said – WIP means that you're still working on PR == is not ready for merge. If PR is ready to merge, the WIP tag is confusing.

Yes, but it does not make sense to keep the WIP tag when you really want to merge :smiley_cat: As we said – WIP means that you're still working on PR == is not ready for merge. If PR is ready to merge, the WIP tag is confusing.
Değişiklik isteği 8b1ffe85f3 olarak birleştirildi.
Bu konuşmaya katılmak için oturum aç.
Değerlendirici yok
Kilometre Taşı Yok
Atanan Kişi Yok
3 Katılımcı
Bildirimler
Bitiş Tarihi

Bitiş tarihi atanmadı.

Bağımlılıklar

Bağımlılık yok.

Referans: TDE/tqca-tls#1
Yükleniyor…
Henüz bir içerik yok.