Fix portability for expr(1) usage #1

已合併
SlavekB 5 年之前 將 1 次代碼提交從 feat/fix-expr-portability 合併至 master
協同者

"match" operand for expr(1) is GNU extension.
Change to use the standard way to match regex with expr(1).

"match" operand for expr(1) is GNU extension. Change to use the standard way to match regex with expr(1).
SlavekB approved these changes 5 年之前
SlavekB left a comment
所有者

Everything looks good.

Everything looks good.
SlavekB changed title from WIP: Fix portability for expr(1) usage to Fix portability for expr(1) usage 5 年之前
SlavekB closed this pull request 5 年之前
SlavekB 刪除分支 feat/fix-expr-portability 5 年之前
所有者

Thanks Obata-san.

Just as a reminder, there is no need to add WIP in the title of the PR.

A PR marked as WIP means you intend to do more work on it and should not be merged yet.

I read the TGW guide again and there is no mentioning of WIP, unless I totally missed it.

Thanks Obata-san. Just as a reminder, there is no need to add WIP in the title of the PR.<br> A PR marked as WIP means you intend to do more work on it and should not be merged yet.<br> I read the TGW guide again and there is no mentioning of WIP, unless I totally missed it.
SlavekB 新增至R14.0.6 release 里程碑 5 年之前
所有者

@obache, you can use a different way. Instead of WIP to the PR name, you can set label PR/rfc. By doing so, you acknowledge that your work is completed and you want us to review the proposed PR.

@obache, you can use a different way. Instead of WIP to the PR name, you can set label PR/rfc. By doing so, you acknowledge that your work is completed and you want us to review the proposed PR.
發佈者
協同者

Have you ever created PR here?

below the title input area:
"Start the title with WIP: to prevent the pull request from being merged accidentally."

Have you ever created PR here? below the title input area: "Start the title with WIP: to prevent the pull request from being merged accidentally."
所有者

Yes, but it does not make sense to keep the WIP tag when you really want to merge 😺

As we said – WIP means that you're still working on PR == is not ready for merge. If PR is ready to merge, the WIP tag is confusing.

Yes, but it does not make sense to keep the WIP tag when you really want to merge :smiley_cat: As we said – WIP means that you're still working on PR == is not ready for merge. If PR is ready to merge, the WIP tag is confusing.
The pull request has been merged as 8b1ffe85f3.
登入 才能加入這對話。
No reviewers
未選擇里程碑
No Assignees
3 參與者
訊息
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tqca-tls#1
Loading…
尚未有任何內容