TDE
/
tqt3
9
0
포크 0
코드 이슈 20 풀 리퀘스트 7 릴리즈 위키 활동
레이블 마일스톤

Change tests for glibc version #12

병합
SlavekB feat/reverse-glibc-v2-tests 에서 master 로 1 commits 를 머지했습니다 5 년 전
대화 2 커밋 1 파일 변경됨 15
SlavekB 코멘트됨, 5 년 전
소유자

It resolves building with libc libraries other than glibc – for example musl libc.

It resolves building with libc libraries other than glibc – for example [musl libc](https://www.musl-libc.org/).
SlavekB R14.0.7 release 5 년 전 마일스톤을 추가하였습니다.
SlavekB added the PR/rfc label 5 년 전
MicheleC 코멘트됨, 5 년 전
소유자

PR looks good, nevertheless I wonder if it still makes sense to check for glibc < 2. Based on release history, glibc 2 was release on 1997-01-26, so we can safely assume that all the systems we are building TDE with glibc are using a version >=2. IMO we could simplify the code into

#define QT_SOCKLEN_T		socklen_t
PR looks good, nevertheless I wonder if it still makes sense to check for glibc < 2. Based on release history, glibc 2 was release on 1997-01-26, so we can safely assume that all the systems we are building TDE with glibc are using a version >=2. IMO we could simplify the code into ``` #define QT_SOCKLEN_T socklen_t ```
SlavekB 코멘트됨, 5 년 전
포스터
소유자

You're right, we can now assume that using glibc will not be older than version 2.

Patch updated.

You're right, we can now assume that using glibc will not be older than version 2. Patch updated.
Ghost closed this pull request 5 년 전
Ghost reopened this pull request 5 년 전
MicheleC 이 변경사항을 승인하였습니다. 5 년 전
MicheleC left a comment
소유자

LGTM.

LGTM.
SlavekB closed this pull request 5 년 전
SlavekB 삭제된 브랜치 feat/reverse-glibc-v2-tests 5 년 전
SlavekB removed the PR/rfc label 5 년 전
The pull request has been merged as 1aa221a2bc.
로그인하여 이 대화에 참여
리뷰어
Request review
No reviewers
레이블
Apply labels
레이블 초기화
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
레이블 없음 GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
마일스톤
Set milestone
마일스톤 초기화
No items
마일스톤 없음
R14.0.7 release
담당자
Assign users
담당자 초기화
담당자 없음
참여자 2명
알림
마감일

마감일이 설정되지 않았습니다.

의존성

No dependencies set.

Reference: TDE/tqt3#12
쓰기 미리보기
불러오는 중...
취소
저장
아직 콘텐츠가 없습니다.
'feat/reverse-glibc-v2-tests' 브랜치 삭제

Deleting a branch is permanent. It CANNOT be undone. Continue?

아니오
예