TDE
/
tqt3
9
0
Fork 0
Code Issues 20 Pull Requests 7 Releases Wiki Activity
Labels Milestones

TQFileDialog: cleanup pixmaps before destroying TQApplication #138

Merged
MicheleC merged 1 commits from other/filedialog-pixmaps-cleanup into master 2 months ago
Conversation 2 Commits 1 Files Changed 1
Fat-Zer commented 2 months ago
Collaborator

Otherwise it results in small memmory leakage on exit of Xlib data.

Otherwise it results in small memmory leakage on exit of Xlib data.
Fat-Zer added 1 commit 2 months ago
9ffacc2652 TQFileDialog: cleanup pixmaps before destroying TQApplication
SlavekB approved these changes 2 months ago
SlavekB left a comment
Owner

It seems good.

It seems good.
MicheleC reviewed 2 months ago
MicheleC left a comment
Owner

Right after the definition of qfd_cleanup_pixmap there is the definition of qfd_cleanup_string in the exact same manner. Seems to me this also requires to be clean up when the application exits. Perhaps we can use the same post routine to clean up both?

Right after the definition of `qfd_cleanup_pixmap` there is the definition of `qfd_cleanup_string` in the exact same manner. Seems to me this also requires to be clean up when the application exits. Perhaps we can use the same post routine to clean up both?
Fat-Zer commented 2 months ago
Poster
Collaborator

Right after the definition of qfd_cleanup_pixmap there is the definition of qfd_cleanup_string in the exact same manner. Seems to me this also requires to be clean up when the application exits. Perhaps we can use the same post routine to clean up both?

TQCleanupHandler will cleanup everything on destruction anyway. The difference is the TQPixmaps should be destroyed before TQApplication, when the TQStrings can safely wait till the destruction of statics. So it's fine to leave those up to mercy of the destructor...

> Right after the definition of qfd_cleanup_pixmap there is the definition of qfd_cleanup_string in the exact same manner. Seems to me this also requires to be clean up when the application exits. Perhaps we can use the same post routine to clean up both? `TQCleanupHandler` will cleanup everything on destruction anyway. The difference is the TQPixmaps should be destroyed before TQApplication, when the TQStrings can safely wait till the destruction of statics. So it's fine to leave those up to mercy of the destructor...
MicheleC commented 2 months ago
Owner

Ah ah, I see. Thanks for the clarification.

Btw, you should have an email from Slavek in your inbox from a few days ago, in case you missed that @Fat-Zer

Ah ah, I see. Thanks for the clarification. Btw, you should have an email from Slavek in your inbox from a few days ago, in case you missed that @Fat-Zer
MicheleC force-pushed other/filedialog-pixmaps-cleanup from 9ffacc2652 to fb0d62eec8 2 months ago
MicheleC merged commit fb0d62eec8 into master 2 months ago
MicheleC deleted branch other/filedialog-pixmaps-cleanup 2 months ago
MicheleC added this to the R14.1.2 release milestone 2 months ago

Reviewers

SlavekB approved these changes 2 months ago
The pull request has been merged as fb0d62eec8.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.2 release
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tqt3#138
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'other/filedialog-pixmaps-cleanup'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes