TDE
/
tqtinterface
6
0
Fork 0
Code Issues Pull Requests 1 Releases Wiki Activity
Labels Milestones

Allow tqtinterface to build without OpenGL support. #3

Manually merged
Ghost merged 1 commits from bug/2645 into master 4 years ago
Conversation 10 Commits 1 Files Changed 5
Ghost commented 4 years ago

This should close bug 2645.
Some cosmetics here and there.

Tested without tqt3/OpenGL support with the removal of the glu package.
Please give It a test.

This should close bug 2645. Some cosmetics here and there. Tested without tqt3/OpenGL support with the removal of the glu package. Please give It a test.
Ghost added the PR/wip label 4 years ago
Ghost changed title from WIP:Allow tqtinterface to build without OpenGL support. to Allow tqtinterface to build without OpenGL support. 4 years ago
Ghost added the PR/rfc label 4 years ago
Ghost removed the PR/wip label 4 years ago
Ghost changed title from Allow tqtinterface to build without OpenGL support. to WIP:Allow tqtinterface to build without OpenGL support. 4 years ago
Ghost added PR/wip and removed PR/rfc labels 4 years ago
Ghost changed title from WIP:Allow tqtinterface to build without OpenGL support. to Allow tqtinterface to build without OpenGL support. 4 years ago
Ghost added PR/rfc and removed PR/wip labels 4 years ago
Chris commented 4 years ago
Collaborator

I have tested your work and it's working fine, with and without glu or TQt build with, or without OpenGL support. 😸

It's wonderful you fixed that longstanding problem. 👍

I have tested your work and it's working fine, with and without glu or TQt build with, or without OpenGL support. :smile_cat: It's wonderful you fixed that longstanding problem. :+1:
Chris commented 4 years ago
Collaborator

By chance I noticed some message while testing:

-- Looking for OpenGL/glu.h
CMake Warning (dev) at /usr/share/cmake/Modules/CheckIncludeFile.cmake:80 (message):
Policy CMP0075 is not set: Include file check macros honor
CMAKE_REQUIRED_LIBRARIES. Run "cmake --help-policy CMP0075" for policy
details. Use the cmake_policy command to set the policy and suppress this
warning.

CMAKE_REQUIRED_LIBRARIES is set to:

-L/usr/tqt3/lib;tqt-mt

For compatibility with CMake 3.11 and below this check is ignoring it.
Call Stack (most recent call first):
ConfigureChecks.cmake:176 (check_include_file)
CMakeLists.txt:66 (include)
This warning is for project developers. Use -Wno-dev to suppress it.

With dev-util/cmake-3.17.1.

By chance I noticed some message while testing: > -- Looking for OpenGL/glu.h > CMake Warning (dev) at /usr/share/cmake/Modules/CheckIncludeFile.cmake:80 (message): > Policy CMP0075 is not set: Include file check macros honor > CMAKE_REQUIRED_LIBRARIES. Run "cmake --help-policy CMP0075" for policy > details. Use the cmake_policy command to set the policy and suppress this > warning. > > CMAKE_REQUIRED_LIBRARIES is set to: > > -L/usr/tqt3/lib;tqt-mt > > For compatibility with CMake 3.11 and below this check is ignoring it. > Call Stack (most recent call first): > ConfigureChecks.cmake:176 (check_include_file) > CMakeLists.txt:66 (include) > This warning is for project developers. Use -Wno-dev to suppress it. With `dev-util/cmake-3.17.1`.
Ghost commented 4 years ago
Poster

@Chris Thanks for your feedback. 👍

I hope Slavek will have some spare time to give It a try soon, expect some changes, as a programmer, he's got higher standards than I.

Reading this PR (again), I'd say that since opengl config variable is now searched into the tqt's pkgconfig file, tde_message_fatal is probably not needed anymore.

Regarding the warning, I don't have an ideas yet. Maybe, I removed something that I shouldn't have...to be continued!

@Chris Thanks for your feedback. :thumbsup: I hope Slavek will have some spare time to give It a try soon, expect some changes, as a programmer, he's got higher standards than I. Reading this PR (again), I'd say that since opengl config variable is now searched into the tqt's pkgconfig file, tde_message_fatal is probably not needed anymore. Regarding the warning, I don't have an ideas yet. Maybe, I removed something that I shouldn't have...to be continued!
👍 1
SlavekB commented 4 years ago
Owner

I made a small update that should resolve the CMP0075 message. You can test it.

I made a small update that should resolve the CMP0075 message. You can test it.
SlavekB commented 4 years ago
Owner
  • Added usual big-endian and large files tests.
  • execute_process is used instead of deprecated exec_program.
+ Added usual big-endian and large files tests. + `execute_process` is used instead of deprecated `exec_program`.
SlavekB commented 4 years ago
Owner

Please can anyone verify if ntqgl.h is installed when building TQt3 without OpenGL support? If not, then tqgl.h should not be installed in tqtinterface.

Please can anyone verify if `ntqgl.h` is installed when building TQt3 without OpenGL support? If not, then `tqgl.h` should not be installed in tqtinterface.
Chris commented 4 years ago
Collaborator

Some report: The message is away now. Great, @SlavekB! 👍

About TQt3, I will report later.

Some report: The message is away now. Great, @SlavekB! :+1: About TQt3, I will report later.
Chris commented 4 years ago
Collaborator

Report: ntqgl.h is there. 👍

Report: `ntqgl.h` is there. :+1:
SlavekB commented 4 years ago
Owner

Ok, so even tqgl.h should always be installed and therefore no further changes are needed and we can proceed to the merge.

Ok, so even `tqgl.h` should always be installed and therefore no further changes are needed and we can proceed to the merge.
👍 1
SlavekB removed the PR/rfc label 4 years ago
Ghost closed this pull request 4 years ago
SlavekB added this to the R14.0.9 release milestone 4 years ago
SlavekB commented 4 years ago
Owner

With some modifications related to r14.0.x branch backported to R14.0.9.

With some modifications related to r14.0.x branch backported to R14.0.9.
MicheleC deleted branch bug/2645 5 months ago
The pull request has been manually merged as 5cdb545740.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.9 release
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Blocks
#144 Live ebuilds: Add `opengl` USE and fix `glu` dependency of tqtinterface.
TDE/tde-packaging-gentoo
Reference: TDE/tqtinterface#3
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'bug/2645'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes