Allow tqtinterface to build without OpenGL support. #3

Manually merged
cethyel merged 1 commits from bug/2645 into master 1 year ago
cethyel commented 1 year ago
Collaborator

This should close bug 2645.
Some cosmetics here and there.

Tested without tqt3/OpenGL support with the removal of the glu package.
Please give It a test.

This should close bug 2645. Some cosmetics here and there. Tested without tqt3/OpenGL support with the removal of the glu package. Please give It a test.
cethyel added the
PR/wip
label 1 year ago
cethyel changed title from WIP:Allow tqtinterface to build without OpenGL support. to Allow tqtinterface to build without OpenGL support. 1 year ago
cethyel added the
PR/rfc
label 1 year ago
cethyel removed the
PR/wip
label 1 year ago
cethyel changed title from Allow tqtinterface to build without OpenGL support. to WIP:Allow tqtinterface to build without OpenGL support. 1 year ago
cethyel added
PR/wip
and removed
PR/rfc
labels 1 year ago
cethyel changed title from WIP:Allow tqtinterface to build without OpenGL support. to Allow tqtinterface to build without OpenGL support. 1 year ago
cethyel added
PR/rfc
and removed
PR/wip
labels 1 year ago
Collaborator

I have tested your work and it's working fine, with and without glu or TQt build with, or without OpenGL support. 😸

It's wonderful you fixed that longstanding problem. 👍

I have tested your work and it's working fine, with and without glu or TQt build with, or without OpenGL support. :smile_cat: It's wonderful you fixed that longstanding problem. :+1:
Collaborator

By chance I noticed some message while testing:

-- Looking for OpenGL/glu.h
CMake Warning (dev) at /usr/share/cmake/Modules/CheckIncludeFile.cmake:80 (message):
Policy CMP0075 is not set: Include file check macros honor
CMAKE_REQUIRED_LIBRARIES. Run "cmake --help-policy CMP0075" for policy
details. Use the cmake_policy command to set the policy and suppress this
warning.

CMAKE_REQUIRED_LIBRARIES is set to:

-L/usr/tqt3/lib;tqt-mt

For compatibility with CMake 3.11 and below this check is ignoring it.
Call Stack (most recent call first):
ConfigureChecks.cmake:176 (check_include_file)
CMakeLists.txt:66 (include)
This warning is for project developers. Use -Wno-dev to suppress it.

With dev-util/cmake-3.17.1.

By chance I noticed some message while testing: > -- Looking for OpenGL/glu.h > CMake Warning (dev) at /usr/share/cmake/Modules/CheckIncludeFile.cmake:80 (message): > Policy CMP0075 is not set: Include file check macros honor > CMAKE_REQUIRED_LIBRARIES. Run "cmake --help-policy CMP0075" for policy > details. Use the cmake_policy command to set the policy and suppress this > warning. > > CMAKE_REQUIRED_LIBRARIES is set to: > > -L/usr/tqt3/lib;tqt-mt > > For compatibility with CMake 3.11 and below this check is ignoring it. > Call Stack (most recent call first): > ConfigureChecks.cmake:176 (check_include_file) > CMakeLists.txt:66 (include) > This warning is for project developers. Use -Wno-dev to suppress it. With `dev-util/cmake-3.17.1`.
Poster
Collaborator

@Chris Thanks for your feedback. 👍

I hope Slavek will have some spare time to give It a try soon, expect some changes, as a programmer, he's got higher standards than I.

Reading this PR (again), I'd say that since opengl config variable is now searched into the tqt's pkgconfig file, tde_message_fatal is probably not needed anymore.

Regarding the warning, I don't have an ideas yet. Maybe, I removed something that I shouldn't have...to be continued!

@Chris Thanks for your feedback. :thumbsup: I hope Slavek will have some spare time to give It a try soon, expect some changes, as a programmer, he's got higher standards than I. Reading this PR (again), I'd say that since opengl config variable is now searched into the tqt's pkgconfig file, tde_message_fatal is probably not needed anymore. Regarding the warning, I don't have an ideas yet. Maybe, I removed something that I shouldn't have...to be continued!
Owner

I made a small update that should resolve the CMP0075 message. You can test it.

I made a small update that should resolve the CMP0075 message. You can test it.
Owner
  • Added usual big-endian and large files tests.
  • execute_process is used instead of deprecated exec_program.
+ Added usual big-endian and large files tests. + `execute_process` is used instead of deprecated `exec_program`.
Owner

Please can anyone verify if ntqgl.h is installed when building TQt3 without OpenGL support? If not, then tqgl.h should not be installed in tqtinterface.

Please can anyone verify if `ntqgl.h` is installed when building TQt3 without OpenGL support? If not, then `tqgl.h` should not be installed in tqtinterface.
Collaborator

Some report: The message is away now. Great, @SlavekB! 👍

About TQt3, I will report later.

Some report: The message is away now. Great, @SlavekB! :+1: About TQt3, I will report later.
Collaborator

Report: ntqgl.h is there. 👍

Report: `ntqgl.h` is there. :+1:
Owner

Ok, so even tqgl.h should always be installed and therefore no further changes are needed and we can proceed to the merge.

Ok, so even `tqgl.h` should always be installed and therefore no further changes are needed and we can proceed to the merge.
SlavekB removed the
PR/rfc
label 1 year ago
cethyel closed this pull request 1 year ago
SlavekB added this to the R14.0.9 release milestone 1 year ago
Owner

With some modifications related to r14.0.x branch backported to R14.0.9.

With some modifications related to r14.0.x branch backported to R14.0.9.
The pull request has been manually merged as 5cdb545740.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Loading…
There is no content yet.