Removed unused scripts and libtqtqui configuration #39
Closed
MicheleC
wants to merge 1 commits from drop/unused-code into master
SlavekB
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'drop/unused-code'
Deleting a branch is permanent. It CANNOT be undone. Continue?
libtqtqui.so was not provided by any package.
MicheleC referenced this pull request from TDE/tde 3 months agoPart concerning
tqtqui.pcnow incorrect. This requires a solution in a separate PR.# tqt.pc and tqtqui.pc definitions# tqt.pc definitionsFile
tqtqui.pcfile is still used.configure_file( tqtqui.pc.cmake tqtqui.pc @ONLY )install( FILES ${CMAKE_CURRENT_BINARY_DIR}/tqt.pc DESTINATION ${PKGCONFIG_INSTALL_DIR} )install( FILES ${CMAKE_CURRENT_BINARY_DIR}/tqtqui.pc DESTINATION ${PKGCONFIG_INSTALL_DIR} )The file needs to be installed.
endforeach( )configure_file( tqt.pc.cmake tqt.pc @ONLY )configure_file( tqtqui.pc.cmake tqtqui.pc @ONLY )The file needs to be generated.
Name: TQtQUIDescription: Interface and abstraction library for Qt and Trinity (QUI library)Version: @TQT_VERSION@Libs: -L${libdir} -ltqt -ltqui -L@TQT_LIBRARY_DIR@ @PC_TQT_LIBRARIES@The pkg-config file is called
tqtqui, but the library itself is in TQt3 and is calledlibtqui.soand it seems to be still used. See comments in TDE/tde-cmake#99. Removing this file therefore seems to be incorrect or, respectively, when merging tqtinterface to TQt3, this file will need to be generated in TQt3. Perhaps with the nametqui.pc, which corresponds to the name of the library.This PR is wrong, I did the wrong checking in first place.
I will make a separate PR for the other files not needed.
Reviewers